mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-11-02 21:33:26 +00:00
Swift Testing for Unit Tests PART 1 (#5119)
* migrated a lot of unit tests to Swift Testing and added a new implementation for deferred fulfillment more tests migration Cleaned the code manually to establish some good patterns more code improvements some more code improvements removed empty tests update project * more pr suggestions and cleanups * removed the TestSetup pattern * fixing claude not reusing tests * pr suggestion + added indent rule to swiftformat so that we can prevent AIs to change that
This commit is contained in:
Mauro
GitHub
@@ -7,18 +7,21 @@
|
||||
//
|
||||
|
||||
@testable import ElementX
|
||||
import XCTest
|
||||
import Foundation
|
||||
import Testing
|
||||
|
||||
@MainActor
|
||||
class NavigationStackCoordinatorTests: XCTestCase {
|
||||
private var navigationStackCoordinator: NavigationStackCoordinator!
|
||||
@Suite
|
||||
struct NavigationStackCoordinatorTests {
|
||||
private var navigationStackCoordinator: NavigationStackCoordinator
|
||||
|
||||
override func setUp() {
|
||||
init() {
|
||||
navigationStackCoordinator = NavigationStackCoordinator()
|
||||
}
|
||||
|
||||
func testRoot() {
|
||||
XCTAssertNil(navigationStackCoordinator.rootCoordinator)
|
||||
@Test
|
||||
func root() {
|
||||
#expect(navigationStackCoordinator.rootCoordinator == nil)
|
||||
|
||||
let rootCoordinator = SomeTestCoordinator()
|
||||
navigationStackCoordinator.setRootCoordinator(rootCoordinator)
|
||||
@@ -26,7 +29,8 @@ class NavigationStackCoordinatorTests: XCTestCase {
|
||||
assertCoordinatorsEqual(rootCoordinator, navigationStackCoordinator.rootCoordinator)
|
||||
}
|
||||
|
||||
func testSingleSheet() {
|
||||
@Test
|
||||
mutating func singleSheet() {
|
||||
let rootCoordinator = SomeTestCoordinator()
|
||||
navigationStackCoordinator.setRootCoordinator(rootCoordinator)
|
||||
|
||||
@@ -39,10 +43,11 @@ class NavigationStackCoordinatorTests: XCTestCase {
|
||||
navigationStackCoordinator.setSheetCoordinator(nil)
|
||||
|
||||
assertCoordinatorsEqual(rootCoordinator, navigationStackCoordinator.rootCoordinator)
|
||||
XCTAssertNil(navigationStackCoordinator.sheetCoordinator)
|
||||
#expect(navigationStackCoordinator.sheetCoordinator == nil)
|
||||
}
|
||||
|
||||
func testMultipleSheets() {
|
||||
@Test
|
||||
mutating func multipleSheets() {
|
||||
let rootCoordinator = SomeTestCoordinator()
|
||||
navigationStackCoordinator.setRootCoordinator(rootCoordinator)
|
||||
|
||||
@@ -50,18 +55,19 @@ class NavigationStackCoordinatorTests: XCTestCase {
|
||||
navigationStackCoordinator.setSheetCoordinator(sheetCoordinator)
|
||||
|
||||
assertCoordinatorsEqual(rootCoordinator, navigationStackCoordinator.rootCoordinator)
|
||||
XCTAssert(navigationStackCoordinator.stackCoordinators.isEmpty)
|
||||
#expect(navigationStackCoordinator.stackCoordinators.isEmpty)
|
||||
assertCoordinatorsEqual(sheetCoordinator, navigationStackCoordinator.sheetCoordinator)
|
||||
|
||||
let someOtherSheetCoordinator = SomeTestCoordinator()
|
||||
navigationStackCoordinator.setSheetCoordinator(someOtherSheetCoordinator)
|
||||
|
||||
assertCoordinatorsEqual(rootCoordinator, navigationStackCoordinator.rootCoordinator)
|
||||
XCTAssert(navigationStackCoordinator.stackCoordinators.isEmpty)
|
||||
#expect(navigationStackCoordinator.stackCoordinators.isEmpty)
|
||||
assertCoordinatorsEqual(someOtherSheetCoordinator, navigationStackCoordinator.sheetCoordinator)
|
||||
}
|
||||
|
||||
func testSinglePush() {
|
||||
@Test
|
||||
mutating func singlePush() {
|
||||
let rootCoordinator = SomeTestCoordinator()
|
||||
navigationStackCoordinator.setRootCoordinator(rootCoordinator)
|
||||
|
||||
@@ -74,10 +80,11 @@ class NavigationStackCoordinatorTests: XCTestCase {
|
||||
navigationStackCoordinator.pop()
|
||||
|
||||
assertCoordinatorsEqual(rootCoordinator, navigationStackCoordinator.rootCoordinator)
|
||||
XCTAssert(navigationStackCoordinator.stackCoordinators.isEmpty)
|
||||
#expect(navigationStackCoordinator.stackCoordinators.isEmpty)
|
||||
}
|
||||
|
||||
func testMultiplePushes() {
|
||||
@Test
|
||||
mutating func multiplePushes() {
|
||||
let rootCoordinator = SomeTestCoordinator()
|
||||
navigationStackCoordinator.setRootCoordinator(rootCoordinator)
|
||||
|
||||
@@ -89,7 +96,7 @@ class NavigationStackCoordinatorTests: XCTestCase {
|
||||
}
|
||||
|
||||
assertCoordinatorsEqual(rootCoordinator, navigationStackCoordinator.rootCoordinator)
|
||||
XCTAssertEqual(navigationStackCoordinator.stackCoordinators.count, coordinators.count)
|
||||
#expect(navigationStackCoordinator.stackCoordinators.count == coordinators.count)
|
||||
|
||||
for index in coordinators.indices {
|
||||
assertCoordinatorsEqual(coordinators[index], navigationStackCoordinator.stackCoordinators[index])
|
||||
@@ -98,10 +105,11 @@ class NavigationStackCoordinatorTests: XCTestCase {
|
||||
navigationStackCoordinator.popToRoot()
|
||||
|
||||
assertCoordinatorsEqual(rootCoordinator, navigationStackCoordinator.rootCoordinator)
|
||||
XCTAssert(navigationStackCoordinator.stackCoordinators.isEmpty)
|
||||
#expect(navigationStackCoordinator.stackCoordinators.isEmpty)
|
||||
}
|
||||
|
||||
func testRootReplacementDimissesTheRest() {
|
||||
@Test
|
||||
mutating func rootReplacementDimissesTheRest() {
|
||||
let rootCoordinator = SomeTestCoordinator()
|
||||
navigationStackCoordinator.setRootCoordinator(rootCoordinator)
|
||||
|
||||
@@ -119,10 +127,11 @@ class NavigationStackCoordinatorTests: XCTestCase {
|
||||
navigationStackCoordinator.setRootCoordinator(newRootCoordinator)
|
||||
|
||||
assertCoordinatorsEqual(newRootCoordinator, navigationStackCoordinator.rootCoordinator)
|
||||
XCTAssert(navigationStackCoordinator.stackCoordinators.isEmpty)
|
||||
#expect(navigationStackCoordinator.stackCoordinators.isEmpty)
|
||||
}
|
||||
|
||||
func testPushesDontReplaceSheet() {
|
||||
@Test
|
||||
mutating func pushesDontReplaceSheet() {
|
||||
let sheetCoordinator = SomeTestCoordinator()
|
||||
navigationStackCoordinator.setSheetCoordinator(sheetCoordinator)
|
||||
|
||||
@@ -142,54 +151,57 @@ class NavigationStackCoordinatorTests: XCTestCase {
|
||||
|
||||
// MARK: - Dismissal Callbacks
|
||||
|
||||
func testPopDismissalCallbacks() {
|
||||
@Test
|
||||
mutating func popDismissalCallbacks() async {
|
||||
let pushedCoordinator = SomeTestCoordinator()
|
||||
|
||||
let expectation = expectation(description: "Wait for callback")
|
||||
navigationStackCoordinator.push(pushedCoordinator) {
|
||||
expectation.fulfill()
|
||||
await confirmation("Wait for callback") { confirm in
|
||||
navigationStackCoordinator.push(pushedCoordinator) {
|
||||
confirm()
|
||||
}
|
||||
|
||||
navigationStackCoordinator.pop()
|
||||
}
|
||||
|
||||
navigationStackCoordinator.pop()
|
||||
waitForExpectations(timeout: 1.0)
|
||||
}
|
||||
|
||||
func testPopToRootDismissalCallbacks() {
|
||||
@Test
|
||||
mutating func popToRootDismissalCallbacks() async {
|
||||
navigationStackCoordinator.push(SomeTestCoordinator())
|
||||
navigationStackCoordinator.push(SomeTestCoordinator())
|
||||
|
||||
let coordinator = SomeTestCoordinator()
|
||||
let expectation = expectation(description: "Wait for callback")
|
||||
navigationStackCoordinator.push(coordinator) {
|
||||
expectation.fulfill()
|
||||
await confirmation("Wait for callback") { confirm in
|
||||
navigationStackCoordinator.push(coordinator) {
|
||||
confirm()
|
||||
}
|
||||
|
||||
navigationStackCoordinator.popToRoot()
|
||||
}
|
||||
|
||||
navigationStackCoordinator.popToRoot()
|
||||
waitForExpectations(timeout: 1.0)
|
||||
}
|
||||
|
||||
func testSheetDismissalCallback() {
|
||||
@Test
|
||||
mutating func sheetDismissalCallback() async {
|
||||
let coordinator = SomeTestCoordinator()
|
||||
let expectation = expectation(description: "Wait for callback")
|
||||
navigationStackCoordinator.setSheetCoordinator(coordinator) {
|
||||
expectation.fulfill()
|
||||
await confirmation("Wait for callback") { confirm in
|
||||
navigationStackCoordinator.setSheetCoordinator(coordinator) {
|
||||
confirm()
|
||||
}
|
||||
|
||||
navigationStackCoordinator.setSheetCoordinator(nil)
|
||||
}
|
||||
|
||||
navigationStackCoordinator.setSheetCoordinator(nil)
|
||||
waitForExpectations(timeout: 1.0)
|
||||
}
|
||||
|
||||
func testRootReplacementCallbacks() {
|
||||
@Test
|
||||
mutating func rootReplacementCallbacks() async {
|
||||
navigationStackCoordinator.setRootCoordinator(SomeTestCoordinator())
|
||||
|
||||
let popExpectation = expectation(description: "Waiting for callback")
|
||||
navigationStackCoordinator.push(SomeTestCoordinator()) {
|
||||
popExpectation.fulfill()
|
||||
await confirmation("Waiting for callback") { confirm in
|
||||
navigationStackCoordinator.push(SomeTestCoordinator()) {
|
||||
confirm()
|
||||
}
|
||||
|
||||
navigationStackCoordinator.setRootCoordinator(SomeTestCoordinator())
|
||||
}
|
||||
|
||||
navigationStackCoordinator.setRootCoordinator(SomeTestCoordinator())
|
||||
|
||||
waitForExpectations(timeout: 1.0)
|
||||
}
|
||||
|
||||
// MARK: - Private
|
||||
@@ -197,11 +209,11 @@ class NavigationStackCoordinatorTests: XCTestCase {
|
||||
private func assertCoordinatorsEqual(_ lhs: CoordinatorProtocol?, _ rhs: CoordinatorProtocol?) {
|
||||
guard let lhs = lhs as? SomeTestCoordinator,
|
||||
let rhs = rhs as? SomeTestCoordinator else {
|
||||
XCTFail("Coordinators are not the same")
|
||||
Issue.record("Coordinators are not the same")
|
||||
return
|
||||
}
|
||||
|
||||
XCTAssertEqual(lhs.id, rhs.id)
|
||||
#expect(lhs.id == rhs.id)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user