Swift Testing for Unit Tests PART 1 (#5119)

* migrated a lot of unit tests to Swift Testing and added a new implementation for deferred fulfillment

more tests migration

Cleaned the code manually to establish some good patterns

more code improvements

some more code improvements

removed empty tests

update project

* more pr suggestions and cleanups

* removed the TestSetup pattern

* fixing claude not reusing tests

* pr suggestion + added indent rule to swiftformat so that we can prevent AIs to change that
This commit is contained in:
Mauro
2026-02-19 16:20:47 +01:00
committed by GitHub
parent fc03e05697
commit 7982aef855
118 changed files with 4630 additions and 4129 deletions
@@ -7,44 +7,40 @@
//
@testable import ElementX
import Foundation
import MatrixRustSDK
import MatrixRustSDKMocks
import XCTest
import Testing
final class MediaLoaderTests: XCTestCase {
func testMediaRequestCoalescing() async throws {
@Suite
struct MediaLoaderTests {
@Test
func mediaRequestCoalescing() async throws {
let mediaLoadingClient = ClientSDKMock()
mediaLoadingClient.getMediaContentMediaSourceReturnValue = Data()
let mediaLoader = MediaLoader(client: mediaLoadingClient)
let mediaSource = try MediaSourceProxy(url: .mockMXCFile, mimeType: nil)
do {
for _ in 1...10 {
_ = try await mediaLoader.loadMediaContentForSource(mediaSource)
}
XCTAssertEqual(mediaLoadingClient.getMediaContentMediaSourceCallsCount, 10)
} catch {
fatalError()
for _ in 1...10 {
_ = try await mediaLoader.loadMediaContentForSource(mediaSource)
}
#expect(mediaLoadingClient.getMediaContentMediaSourceCallsCount == 10)
}
func testMediaThumbnailRequestCoalescing() async throws {
@Test
func mediaThumbnailRequestCoalescing() async throws {
let mediaLoadingClient = ClientSDKMock()
mediaLoadingClient.getMediaThumbnailMediaSourceWidthHeightReturnValue = Data()
let mediaLoader = MediaLoader(client: mediaLoadingClient)
let mediaSource = try MediaSourceProxy(url: .mockMXCImage, mimeType: nil)
do {
for _ in 1...10 {
_ = try await mediaLoader.loadMediaThumbnailForSource(mediaSource, width: 100, height: 100)
}
XCTAssertEqual(mediaLoadingClient.getMediaThumbnailMediaSourceWidthHeightCallsCount, 10)
} catch {
fatalError()
for _ in 1...10 {
_ = try await mediaLoader.loadMediaThumbnailForSource(mediaSource, width: 100, height: 100)
}
#expect(mediaLoadingClient.getMediaThumbnailMediaSourceWidthHeightCallsCount == 10)
}
}