Swift Testing for Unit Tests PART 1 (#5119)

* migrated a lot of unit tests to Swift Testing and added a new implementation for deferred fulfillment

more tests migration

Cleaned the code manually to establish some good patterns

more code improvements

some more code improvements

removed empty tests

update project

* more pr suggestions and cleanups

* removed the TestSetup pattern

* fixing claude not reusing tests

* pr suggestion + added indent rule to swiftformat so that we can prevent AIs to change that

UnitTests/Sources/AudioRecorderTests.swift

@@ -9,14 +9,15 @@
 import Combine
 @testable import ElementX
 import Foundation
-import XCTest
+import Testing
 
 @MainActor
-class AudioRecorderTests: XCTestCase {
+@Suite
+struct AudioRecorderTests {
     private var audioRecorder: AudioRecorder!
     private var audioSessionMock: AudioSessionMock!
     
-    override func setUp() async throws {
+    init() async {
         audioSessionMock = AudioSessionMock()
         audioSessionMock.requestRecordPermissionClosure = { completion in
             completion(true)
@@ -24,11 +25,8 @@ class AudioRecorderTests: XCTestCase {
         audioRecorder = AudioRecorder(audioSession: audioSessionMock)
     }
     
-    override func tearDown() async throws {
-        await audioRecorder?.cancelRecording()
-    }
-    
-    func testRecordWithoutPermission() async throws {
+    @Test
+    mutating func recordWithoutPermission() async throws {
         audioSessionMock.requestRecordPermissionClosure = { completion in
             completion(false)
         }
@@ -44,6 +42,6 @@ class AudioRecorderTests: XCTestCase {
         let url = URL.temporaryDirectory.appendingPathComponent("test-voice-message").appendingPathExtension("m4a")
         await audioRecorder.record(audioFileURL: url)
         try await deferred.fulfill()
-        XCTAssertFalse(audioRecorder.isRecording)
+        #expect(!audioRecorder.isRecording)
     }
 }