Swift Testing for Unit Tests PART 1 (#5119)

* migrated a lot of unit tests to Swift Testing and added a new implementation for deferred fulfillment

more tests migration

Cleaned the code manually to establish some good patterns

more code improvements

some more code improvements

removed empty tests

update project

* more pr suggestions and cleanups

* removed the TestSetup pattern

* fixing claude not reusing tests

* pr suggestion + added indent rule to swiftformat so that we can prevent AIs to change that
This commit is contained in:
Mauro
2026-02-19 16:20:47 +01:00
committed by GitHub
parent fc03e05697
commit 7982aef855
118 changed files with 4630 additions and 4129 deletions
@@ -7,39 +7,40 @@
//
@testable import ElementX
import XCTest
import Testing
@MainActor
class AppLockSetupSettingsScreenViewModelTests: XCTestCase {
var appLockService: AppLockServiceProtocol!
var keychainController: KeychainControllerMock!
var viewModel: AppLockSetupSettingsScreenViewModelProtocol!
@Suite
struct AppLockSetupSettingsScreenViewModelTests {
var appLockService: AppLockServiceProtocol
var keychainController: KeychainControllerMock
var viewModel: AppLockSetupSettingsScreenViewModelProtocol
var context: AppLockSetupSettingsScreenViewModelType.Context {
viewModel.context
}
override func setUpWithError() throws {
init() {
keychainController = KeychainControllerMock()
appLockService = AppLockService(keychainController: keychainController, appSettings: AppSettings())
viewModel = AppLockSetupSettingsScreenViewModel(appLockService: AppLockServiceMock.mock())
}
func testDisablingShowsAlert() {
@Test
func disablingShowsAlert() {
// Given a fresh screen with the PIN code enabled.
let pinCode = "2023"
keychainController.pinCodeReturnValue = pinCode
keychainController.containsPINCodeReturnValue = true
XCTAssertNil(context.alertInfo)
XCTAssertTrue(appLockService.isEnabled)
#expect(context.alertInfo == nil)
#expect(appLockService.isEnabled)
// When disabling the PIN code lock.
context.send(viewAction: .disable)
// Then an alert should be shown before disabling it.
XCTAssertNotNil(context.alertInfo)
XCTAssertTrue(appLockService.isEnabled)
#expect(context.alertInfo != nil)
#expect(appLockService.isEnabled)
}
}