ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-10-31 08:15:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Throw from session directories and only fatal error when making sense.

Browse Source
This commit is contained in:
Stefan Ceriu
2026-09-30 11:36:06 +03:00
parent a8bc26dc93
commit 7973da8251
5 changed files with 21 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
UnitTests/Sources/SessionDirectoriesTests.swift
+3 -3
View File
@@ -55,7 +55,7 @@ struct SessionDirectoriesTests {
#expect(fileManager.directoryExists(at: sessionDirectories.cacheDirectory))
// When deleting the directories.
sessionDirectories.delete()
try? sessionDirectories.delete()
// Then neither directory should exist on disk.
#expect(!fileManager.directoryExists(at: sessionDirectories.dataDirectory))
@@ -79,7 +79,7 @@ struct SessionDirectoriesTests {
#expect(try fileManager.numberOfItems(at: sessionDirectories.cacheDirectory) == 3)
// When deleting transient user data.
sessionDirectories.deleteTransientUserData()
try? sessionDirectories.deleteTransientUserData()
// Then the data directory should only contain the crypto store and the cache directory should remain but be empty.
#expect(fileManager.directoryExists(at: sessionDirectories.dataDirectory))
@@ -92,6 +92,6 @@ struct SessionDirectoriesTests {
#expect(!fileManager.fileExists(atPath: sessionDirectories.mockEventCachePath))
// The tests are done, tidy up these useless directories 🧹
sessionDirectories.delete()
try? sessionDirectories.delete()
}
}
UnitTests/Sources/UserSessionStoreTests.swift
+2 -2
View File
@@ -73,7 +73,7 @@ struct UserSessionStoreTests {
func restoreWhenClientCreationFails() async throws {
// Given valid session data but a client factory that fails.
let sessionDirectories = try makeValidSessionDirectories()
defer { sessionDirectories.delete() }
defer { try? sessionDirectories.delete() }
let credentials = makeCredentials(sessionDirectories: sessionDirectories)
keychainController.restorationTokensReturnValue = [credentials]
clientFactory.makeAppClientCredentialsClientSessionDelegateAppSettingsAppHooksThrowableError = TestError.generic
@@ -92,7 +92,7 @@ struct UserSessionStoreTests {
func restoreSucceeds() async throws {
// Given valid session data and a client factory that returns a client.
let sessionDirectories = try makeValidSessionDirectories()
defer { sessionDirectories.delete() }
defer { try? sessionDirectories.delete() }
keychainController.restorationTokensReturnValue = [makeCredentials(sessionDirectories: sessionDirectories)]
// When restoring the session.