Prompt user when inviting users with uncached identities (#5331)

If the user attempts to invite someone (to a room or creating a DM) whose identity is not cached, we prompt them to make sure this was their intention.
2026-11-02 12:07:55 +00:00 · 2026-04-14 12:51:58 +01:00
parent fe2319cada
commit 78240ebdee
45 changed files with 541 additions and 40 deletions
@@ -0,0 +1,74 @@
+//
+// Copyright 2026 Element Creations Ltd.
+//
+// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial.
+// Please see LICENSE files in the repository root for full details.
+//
+
+import Compound
+import SwiftUI
+
+struct InviteUsersConfirmationSheetView: View {
+    @ObservedObject var context: InviteUsersScreenViewModel.Context
+    
+    /// The users whose identities we wish the user to confirm.
+    var users: [UserProfileProxy]
+    
+    var body: some View {
+        FullscreenDialog(topPadding: 24, horizontalPadding: 24) {
+            VStack(spacing: 32) {
+                TitleAndIcon(title: L10n.screenInviteUsersConfirmDialogTitle(users.count),
+                             subtitle: L10n.screenInviteUsersConfirmDialogSubtitle(users.count),
+                             icon: \.userAddSolid,
+                             iconStyle: .defaultSolid)
+                VStack(spacing: 0) {
+                    ForEach(users, id: \.userID) { user in
+                        UserProfileListRow(user: user,
+                                           membership: nil,
+                                           mediaProvider: context.mediaProvider,
+                                           kind: .label)
+                            .rowDivider(alignment: .top)
+                            .accessibilityIdentifier(A11yIdentifiers.inviteUsersScreen.userProfile)
+                    }
+                }
+            }
+        } bottomContent: {
+            HStack(spacing: 32) {
+                Button(L10n.actionRemove, role: .cancel) {
+                    context.send(viewAction: .removeUnknownUsers)
+                }
+                .buttonStyle(.compound(.secondary))
+                
+                Button(L10n.actionInvite) {
+                    context.send(viewAction: .confirmUnknownUsers)
+                }
+                .buttonStyle(.compound(.primary))
+            }
+        }
+        .background()
+        .backgroundStyle(.compound.bgCanvasDefault)
+        .interactiveDismissDisabled()
+    }
+}
+
+struct InviteUsersConfirmationSheetView_Previews: PreviewProvider, TestablePreview {
+    static var viewModel = makeViewModel()
+    
+    static var previews: some View {
+        InviteUsersConfirmationSheetView(context: viewModel.context, users: [.mockAlice, .mockCharlie, .mockBob, .mockDan])
+            .previewDisplayName("Default")
+    }
+    
+    static func makeViewModel() -> InviteUsersScreenViewModel {
+        let viewModel = InviteUsersScreenViewModel(userSession: UserSessionMock(.init(clientProxy: ClientProxyMock(.init()))),
+                                                   roomProxy: JoinedRoomProxyMock(.init(members: [])),
+                                                   isSkippable: true,
+                                                   userDiscoveryService: UserDiscoveryServiceMock(),
+                                                   userIndicatorController: UserIndicatorControllerMock(),
+                                                   appSettings: ServiceLocator.shared.settings)
+        
+        viewModel.state.usersToConfirm = [.mockAlice, .mockCharlie, .mockBob, .mockDan]
+        
+        return viewModel
+    }
+}
@@ -31,6 +31,9 @@ struct InviteUsersScreen: View {
                              disablesInteractiveDismiss: true,
                              accessibilityFocusOnStart: true)
            .compoundSearchField()
+            .sheet(isPresented: $context.presentConfirmationDialog) {
+                InviteUsersConfirmationSheetView(context: context, users: context.viewState.usersToConfirm)
+            }
            .alert(item: $context.alertInfo)
            .navigationBarBackButtonHidden(context.viewState.isSkippable)
    }
@@ -149,6 +152,7 @@ struct InviteUsersScreen_Previews: PreviewProvider, TestablePreview {
    static let viewModel = makeViewModel()
    static let searchingViewModel = makeViewModel(searchQuery: "Alice")
    static let selectedViewModel = makeViewModel(hasSelection: true)
+    static let confirmSelectedViewModel = makeViewModel(shouldConfirm: true)
    
    static var previews: some View {
        ElementNavigationStack {
@@ -170,9 +174,14 @@ struct InviteUsersScreen_Previews: PreviewProvider, TestablePreview {
        }
        .previewDisplayName("Selected")
        .snapshotPreferences(expect: selectedViewModel.context.$viewState.map { !$0.selectedUsers.isEmpty })
+        
+        ElementNavigationStack {
+            InviteUsersScreen(context: confirmSelectedViewModel.context)
+        }
+        .previewDisplayName("Confirm Selected")
    }
    
-    static func makeViewModel(searchQuery: String? = nil, hasSelection: Bool = false) -> InviteUsersScreenViewModel {
+    static func makeViewModel(searchQuery: String? = nil, hasSelection: Bool = false, shouldConfirm: Bool = false) -> InviteUsersScreenViewModel {
        let clientProxy = ClientProxyMock(.init())
        clientProxy.recentConversationCounterpartsReturnValue = [.mockAlice, .mockBob, .mockCharlie, .mockDan, .mockVerbose]
        
@@ -194,6 +203,11 @@ struct InviteUsersScreen_Previews: PreviewProvider, TestablePreview {
            viewModel.state.selectedUsers = [.mockAlice]
        }
        
+        if shouldConfirm {
+            viewModel.state.usersToConfirm = [.mockAlice, .mockAlice, .mockAlice, .mockAlice, .mockAlice, .mockAlice, .mockAlice, .mockAlice, .mockAlice]
+            viewModel.state.bindings.presentConfirmationDialog = true
+        }
+        
        return viewModel
    }
 }