Various tweaks (#381)

* Add the message delivery status to the plain timeline styler and display it outside of the main content

* Fix glitchy timeline scroll to bottom button

* Fixed bubbled reactions padding

* Simplified the emoji picker, double tapping a timeline item directly opens it now and added a context menu option. Linked it to rust side reaction sending

* Fix the sliding sync cold cache: treat invalidated rooms as filled

* Make splash screen view full screen

* Fix the offline indicator popping up when first setting up the network monitor

* Expose presentationDetents on the NavigationStackCoordinator and start using them for the EmojiPicker

* Fix link tint color

* Linked TimelineReactionsView reaction sending

* Remove now unused/unnecessary classes

* Add changelog

* Fix formatting issue

ElementX/Sources/Services/Authentication/AuthenticationServiceProxy.swift

@@ -95,8 +95,6 @@ class AuthenticationServiceProxy: AuthenticationServiceProxyProtocol {
     
     func login(username: String, password: String, initialDeviceName: String?, deviceId: String?) async -> Result<UserSessionProtocol, AuthenticationServiceError> {
         do {
-            Benchmark.startTrackingForIdentifier("Login", message: "Started new login")
-        
             let client = try await Task.dispatch(on: .global()) {
                 try self.authenticationService.login(username: username,
                                                      password: password,
@@ -104,11 +102,8 @@ class AuthenticationServiceProxy: AuthenticationServiceProxyProtocol {
                                                      deviceId: deviceId)
             }
             
-            Benchmark.endTrackingForIdentifier("Login", message: "Finished login")
             return await userSession(for: client)
         } catch {
-            Benchmark.endTrackingForIdentifier("Login", message: "Login failed")
-            
             MXLog.error("Failed logging in with error: \(error)")
             guard let error = error as? AuthenticationError else { return .failure(.failedLoggingIn) }
             

ElementX/Sources/Services/Room/RoomProxy.swift

@@ -27,7 +27,7 @@ class RoomProxy: RoomProxyProtocol {
     
     private let serialDispatchQueue = DispatchQueue(label: "io.element.elementx.roomproxy.serial")
     
-    private var sendMessageBgTask: BackgroundTaskProtocol?
+    private var sendMessageBackgroundTask: BackgroundTaskProtocol?
     
     private var memberAvatars = [String: String]()
     private var memberDisplayNames = [String: String]()
@@ -151,10 +151,7 @@ class RoomProxy: RoomProxyProtocol {
         
         do {
             let outcome: PaginationOutcome = try await Task.dispatch(on: .global()) {
-                Benchmark.startTrackingForIdentifier("BackPagination \(id)", message: "Backpaginating \(count) message(s) in room \(id)")
-                let outcome = try self.room.paginateBackwards(limit: UInt16(count))
-                Benchmark.endTrackingForIdentifier("BackPagination \(id)", message: "Finished backpaginating \(count) message(s) in room \(id)")
-                return outcome
+                try self.room.paginateBackwards(limit: UInt16(count))
             }
             update(backPaginationOutcome: outcome)
             return .success(())
@@ -164,9 +161,9 @@ class RoomProxy: RoomProxyProtocol {
     }
     
     func sendMessage(_ message: String, inReplyToEventId: String? = nil) async -> Result<Void, RoomProxyError> {
-        sendMessageBgTask = backgroundTaskService.startBackgroundTask(withName: "SendMessage", isReusable: true)
+        sendMessageBackgroundTask = backgroundTaskService.startBackgroundTask(withName: "SendMessage", isReusable: true)
         defer {
-            sendMessageBgTask?.stop()
+            sendMessageBackgroundTask?.stop()
         }
         
         let transactionId = genTransactionId()
@@ -187,15 +184,25 @@ class RoomProxy: RoomProxyProtocol {
     }
     
     func sendReaction(_ reaction: String, for eventId: String) async -> Result<Void, RoomProxyError> {
-        await Task.dispatch(on: .global()) {
-            .success(())
+        sendMessageBackgroundTask = backgroundTaskService.startBackgroundTask(withName: "SendMessage", isReusable: true)
+        defer {
+            sendMessageBackgroundTask?.stop()
+        }
+
+        return await Task.dispatch(on: .global()) {
+            do {
+                try self.room.sendReaction(eventId: eventId, key: reaction)
+                return .success(())
+            } catch {
+                return .failure(.failedSendingReaction)
+            }
         }
     }
 
     func editMessage(_ newMessage: String, originalEventId: String) async -> Result<Void, RoomProxyError> {
-        sendMessageBgTask = backgroundTaskService.startBackgroundTask(withName: "SendMessage", isReusable: true)
+        sendMessageBackgroundTask = backgroundTaskService.startBackgroundTask(withName: "SendMessage", isReusable: true)
         defer {
-            sendMessageBgTask?.stop()
+            sendMessageBackgroundTask?.stop()
         }
 
         let transactionId = genTransactionId()
@@ -205,7 +212,7 @@ class RoomProxy: RoomProxyProtocol {
                 try self.room.edit(newMsg: newMessage, originalEventId: originalEventId, txnId: transactionId)
                 return .success(())
             } catch {
-                return .failure(.failedSendingMessage)
+                return .failure(.failedEditingMessage)
             }
         }
     }

ElementX/Sources/Services/Room/RoomProxyProtocol.swift

@@ -23,6 +23,8 @@ enum RoomProxyError: Error {
     case failedRetrievingMemberAvatarURL
     case failedRetrievingMemberDisplayName
     case failedSendingMessage
+    case failedSendingReaction
+    case failedEditingMessage
     case failedRedactingEvent
     case failedAddingTimelineListener
     case failedRetrievingMembers

ElementX/Sources/Services/Room/RoomSummary/RoomSummaryProvider.swift

@@ -161,8 +161,8 @@ class RoomSummaryProvider: RoomSummaryProviderProtocol {
             return buildEmptyRoomSummary()
         case .filled(let roomId):
             return buildRoomSummaryForIdentifier(roomId)
-        case .invalidated:
-            return buildEmptyRoomSummary()
+        case .invalidated(let roomId):
+            return buildRoomSummaryForIdentifier(roomId)
         }
     }
     

ElementX/Sources/Services/Timeline/Fixtures/RoomTimelineItemFixtures.swift

@@ -64,7 +64,7 @@ enum RoomTimelineItemFixtures {
                              senderId: "",
                              senderDisplayName: "Helena"),
         TextRoomTimelineItem(id: UUID().uuidString,
-                             text: "And John's speech was amazing!",
+                             text: "And John's speech was amazing!And John's speech was amazing!And John's speech was amazing!",
                              timestamp: "5 PM",
                              inGroupState: .beginning,
                              isOutgoing: true,

ElementX/Sources/Services/UserSession/UserSessionStore.swift

@@ -100,8 +100,6 @@ class UserSessionStore: UserSessionStoreProtocol {
     // MARK: - Private
     
     private func restorePreviousLogin(_ credentials: KeychainCredentials) async -> Result<ClientProxyProtocol, UserSessionStoreError> {
-        Benchmark.startTrackingForIdentifier("Login", message: "Started restoring previous login")
-        
         let builder = ClientBuilder()
             .basePath(path: baseDirectory.path)
             .username(username: credentials.userID)