Various tweaks (#381)

* Add the message delivery status to the plain timeline styler and display it outside of the main content

* Fix glitchy timeline scroll to bottom button

* Fixed bubbled reactions padding

* Simplified the emoji picker, double tapping a timeline item directly opens it now and added a context menu option. Linked it to rust side reaction sending

* Fix the sliding sync cold cache: treat invalidated rooms as filled

* Make splash screen view full screen

* Fix the offline indicator popping up when first setting up the network monitor

* Expose presentationDetents on the NavigationStackCoordinator and start using them for the EmojiPicker

* Fix link tint color

* Linked TimelineReactionsView reaction sending

* Remove now unused/unnecessary classes

* Add changelog

* Fix formatting issue

ElementX/Sources/Screens/EmojiPickerScreen/EmojiPickerScreenCoordinator.swift

@@ -23,6 +23,7 @@ struct EmojiPickerScreenCoordinatorParameters {
 
 enum EmojiPickerScreenCoordinatorAction {
     case emojiSelected(emoji: String, itemId: String)
+    case dismiss
 }
 
 final class EmojiPickerScreenCoordinator: CoordinatorProtocol {
@@ -44,12 +45,13 @@ final class EmojiPickerScreenCoordinator: CoordinatorProtocol {
             switch action {
             case let .emojiSelected(emoji: emoji):
                 self.callback?(.emojiSelected(emoji: emoji, itemId: self.parameters.itemId))
+            case .dismiss:
+                self.callback?(.dismiss)
             }
         }
     }
     
     func toPresentable() -> AnyView {
-        AnyView(EmojiPickerScreen(context: viewModel.context)
-            .presentationDetents([.medium, .large]))
+        AnyView(EmojiPickerScreen(context: viewModel.context))
     }
 }

ElementX/Sources/Screens/EmojiPickerScreen/EmojiPickerScreenModels.swift

@@ -18,6 +18,7 @@ import Foundation
 
 enum EmojiPickerScreenViewModelAction {
     case emojiSelected(emoji: String)
+    case dismiss
 }
 
 struct EmojiPickerScreenViewState: BindableState {
@@ -27,6 +28,7 @@ struct EmojiPickerScreenViewState: BindableState {
 enum EmojiPickerScreenViewAction {
     case search(searchString: String)
     case emojiTapped(emoji: EmojiPickerEmojiViewData)
+    case dismiss
 }
 
 struct EmojiPickerEmojiCategoryViewData: Identifiable {

ElementX/Sources/Screens/EmojiPickerScreen/EmojiPickerScreenViewModel.swift

@@ -39,6 +39,8 @@ class EmojiPickerScreenViewModel: EmojiPickerScreenViewModelType, EmojiPickerScr
             state.categories = convert(emojiCategories: categories)
         case let .emojiTapped(emoji: emoji):
             callback?(.emojiSelected(emoji: emoji.value))
+        case .dismiss:
+            callback?(.dismiss)
         }
     }
     

ElementX/Sources/Screens/EmojiPickerScreen/View/EmojiPickerScreen.swift

@@ -21,39 +21,49 @@ struct EmojiPickerScreen: View {
     @State var searchString = ""
     
     var body: some View {
-        VStack {
-            Text(ElementL10n.reactions)
-                .padding(.top, 20)
-            EmojiPickerSearchFieldView(searchString: $searchString)
-                .padding(.horizontal, 10)
-            ScrollView {
-                LazyVGrid(columns: [GridItem(.adaptive(minimum: 45))], spacing: 3) {
-                    ForEach(context.viewState.categories) { category in
-                        Section(header: EmojiPickerHeaderView(title: category.name)
-                            .padding(.horizontal, 13)
-                            .padding(.top, 10)) {
-                                ForEach(category.emojis) { emoji in
-                                    Text(emoji.value)
-                                        .frame(width: 45, height: 45)
-                                        .onTapGesture {
-                                            context.send(viewAction: .emojiTapped(emoji: emoji))
-                                        }
-                                }
+        ScrollView {
+            LazyVGrid(columns: [GridItem(.adaptive(minimum: 45))], spacing: 3) {
+                ForEach(context.viewState.categories) { category in
+                    Section(header: EmojiPickerHeaderView(title: category.name)
+                        .padding(.horizontal, 13)
+                        .padding(.top, 10)) {
+                            ForEach(category.emojis) { emoji in
+                                Text(emoji.value)
+                                    .frame(width: 45, height: 45)
+                                    .onTapGesture {
+                                        context.send(viewAction: .emojiTapped(emoji: emoji))
+                                    }
                             }
-                    }
+                        }
                 }
             }
         }
+        .navigationTitle(ElementL10n.reactions)
+        .navigationBarTitleDisplayMode(.inline)
+        .toolbar { toolbar }
+        .searchable(text: $searchString)
         .onChange(of: searchString) { _ in
             context.send(viewAction: .search(searchString: searchString))
         }
     }
+    
+    @ToolbarContentBuilder
+    var toolbar: some ToolbarContent {
+        ToolbarItem(placement: .cancellationAction) {
+            Button { context.send(viewAction: .dismiss) } label: {
+                Text(ElementL10n.actionCancel)
+            }
+            .accessibilityIdentifier("dismissButton")
+        }
+    }
 }
 
 // MARK: - Previews
 
 struct EmojiPickerScreen_Previews: PreviewProvider {
     static var previews: some View {
-        EmojiPickerScreen(context: EmojiPickerScreenViewModel(emojiProvider: EmojiProvider()).context)
+        NavigationStack {
+            EmojiPickerScreen(context: EmojiPickerScreenViewModel(emojiProvider: EmojiProvider()).context)
+        }
     }
 }

ElementX/Sources/Screens/EmojiPickerScreen/View/EmojiPickerSearchFieldView.swift

@@ -1,45 +0,0 @@
-//
-// Copyright 2022 New Vector Ltd
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-//
-
-import SwiftUI
-
-struct EmojiPickerSearchFieldView: View {
-    @Binding var searchString: String
-    @FocusState private var isSearchFocused: Bool
-    
-    var body: some View {
-        HStack {
-            Image(systemName: "magnifyingglass")
-            TextField(ElementL10n.search, text: $searchString)
-                .focused($isSearchFocused)
-            if isSearchFocused {
-                Spacer()
-                Button {
-                    searchString = ""
-                    isSearchFocused = false
-                } label: {
-                    Text(ElementL10n.actionCancel)
-                }
-            }
-        }
-    }
-}
-
-struct EmojiPickerSearchFieldView_Previews: PreviewProvider {
-    static var previews: some View {
-        EmojiPickerSearchFieldView(searchString: .constant(""))
-    }
-}