Resetting the app after deletion and cleanup settings (#372)

* Fixes #361 - Reset everything if the app has been deleted since the last run

* Cleaned up and renamed the ElementSettings to ApplicationSettings. Removed its singleton and moved it to the service locator.

* Moved the ApplicationSettings to the Application folder

* Merged together the BuildSettings and ApplicationSettings

* Reset the UserDefaults too when resetting the application state

* Rename ServiceLocator.applicationSettings to just settings

* Fix indentation

* Rename ApplicationSettings to AppSettings

* Various tweaks following code review

* Fix unit tests

ElementX/Sources/Screens/Settings/SettingsCoordinator.swift

@@ -50,8 +50,6 @@ final class SettingsCoordinator: CoordinatorProtocol {
                 self.toggleAnalytics()
             case .reportBug:
                 self.presentBugReportScreen()
-            case .crash:
-                self.parameters.bugReportService.crash()
             case .logout:
                 self.callback?(.logout)
             }
@@ -67,7 +65,7 @@ final class SettingsCoordinator: CoordinatorProtocol {
     // MARK: - Private
     
     private func toggleAnalytics() {
-        if ElementSettings.shared.enableAnalytics {
+        if ServiceLocator.shared.settings.enableAnalytics {
             Analytics.shared.optOut()
         } else {
             Analytics.shared.optIn(with: parameters.userSession)

ElementX/Sources/Screens/Settings/SettingsModels.swift

@@ -21,7 +21,6 @@ enum SettingsViewModelAction {
     case close
     case toggleAnalytics
     case reportBug
-    case crash
     case logout
 }
 
@@ -33,13 +32,12 @@ struct SettingsViewState: BindableState {
 }
 
 struct SettingsViewStateBindings {
-    var enableAnalytics = ElementSettings.shared.enableAnalytics
+    var enableAnalytics = ServiceLocator.shared.settings.enableAnalytics
 }
 
 enum SettingsViewAction {
     case close
     case toggleAnalytics
     case reportBug
-    case crash
     case logout
 }

ElementX/Sources/Screens/Settings/SettingsViewModel.swift

@@ -51,8 +51,6 @@ class SettingsViewModel: SettingsViewModelType, SettingsViewModelProtocol {
             callback?(.toggleAnalytics)
         case .reportBug:
             callback?(.reportBug)
-        case .crash:
-            callback?(.crash)
         case .logout:
             callback?(.logout)
         }

ElementX/Sources/Screens/Settings/View/SettingsScreen.swift

@@ -19,7 +19,7 @@ import SwiftUI
 struct SettingsScreen: View {
     @State private var showingLogoutConfirmation = false
     @Environment(\.colorScheme) private var colorScheme
-    @ObservedObject private var settings = ElementSettings.shared
+    @ObservedObject private var settings = ServiceLocator.shared.settings
 
     @ScaledMetric private var avatarSize = AvatarSize.user(on: .settings).value
     @ScaledMetric private var menuIconSize = 30.0
@@ -110,30 +110,20 @@ struct SettingsScreen: View {
             .listRowSeparator(.hidden)
             .foregroundColor(.element.primaryContent)
             .accessibilityIdentifier("reportBugButton")
-
-            if BuildSettings.settingsCrashButtonVisible {
-                Button("Crash app",
-                       role: .destructive) { context.send(viewAction: .crash)
-                }
-                .listRowInsets(listRowInsets)
-                .accessibilityIdentifier("crashButton")
-            }
         }
     }
 
     @ViewBuilder
     private var userInterfaceSection: some View {
-        if BuildSettings.settingsShowTimelineStyle {
-            Section {
-                Picker(ElementL10n.settingsTimelineStyle, selection: $settings.timelineStyle) {
-                    ForEach(TimelineStyle.allCases, id: \.self) { style in
-                        Text(style.description)
-                            .tag(style)
-                    }
+        Section {
+            Picker(ElementL10n.settingsTimelineStyle, selection: $settings.timelineStyle) {
+                ForEach(TimelineStyle.allCases, id: \.self) { style in
+                    Text(style.description)
+                        .tag(style)
                 }
-                .listRowInsets(listRowInsets)
-                .accessibilityIdentifier("timelineStylePicker")
             }
+            .listRowInsets(listRowInsets)
+            .accessibilityIdentifier("timelineStylePicker")
         }
     }