From 6a381dcef0ed148d457c9f933fd3e14aba97a1fa Mon Sep 17 00:00:00 2001
From: Mauro <34335419+Velin92@users.noreply.github.com>
Date: Fri, 19 Jun 2026 11:48:13 +0200
Subject: [PATCH] Fix some issues with missing a11y labels (#5747)

* add a11y label to the bug report field

* include a11y label to the list row directly

* remove is header trait from poll form question header section

* a11y label added to the create room screen name textfield
---
 .../Sources/Screens/CreatePollScreen/View/PollFormScreen.swift | 1 +
 .../Screens/CreateRoomScreen/View/CreateRoomScreen.swift       | 1 +
 compound-ios/Sources/Compound/List/ListRow.swift               | 3 +++
 3 files changed, 5 insertions(+)

diff --git a/ElementX/Sources/Screens/CreatePollScreen/View/PollFormScreen.swift b/ElementX/Sources/Screens/CreatePollScreen/View/PollFormScreen.swift
index 7a455da34..0ce521747 100644
--- a/ElementX/Sources/Screens/CreatePollScreen/View/PollFormScreen.swift
+++ b/ElementX/Sources/Screens/CreatePollScreen/View/PollFormScreen.swift
@@ -48,6 +48,7 @@ struct PollFormScreen: View {
         } header: {
             Text(L10n.screenCreatePollQuestionDesc)
                 .compoundListSectionHeader()
+                .accessibilityRemoveTraits(.isHeader)
         }
     }
     
diff --git a/ElementX/Sources/Screens/CreateRoomScreen/View/CreateRoomScreen.swift b/ElementX/Sources/Screens/CreateRoomScreen/View/CreateRoomScreen.swift
index 9a8c8f089..1e574c61f 100644
--- a/ElementX/Sources/Screens/CreateRoomScreen/View/CreateRoomScreen.swift
+++ b/ElementX/Sources/Screens/CreateRoomScreen/View/CreateRoomScreen.swift
@@ -93,6 +93,7 @@ struct CreateRoomScreen: View {
                         .foregroundStyle(.compound.textPrimary)
                         .tint(.compound.iconAccentTertiary)
                         .focused($focus, equals: .name)
+                        .accessibilityLabel(L10n.commonName)
                         .accessibilityIdentifier(A11yIdentifiers.createRoomScreen.roomName)
                         .padding(.horizontal, ListRowPadding.horizontal)
                         .padding(.vertical, ListRowPadding.vertical)
diff --git a/compound-ios/Sources/Compound/List/ListRow.swift b/compound-ios/Sources/Compound/List/ListRow.swift
index c3e84f70d..f94b47c42 100644
--- a/compound-ios/Sources/Compound/List/ListRow.swift
+++ b/compound-ios/Sources/Compound/List/ListRow.swift
@@ -139,6 +139,8 @@ public struct ListRow<Icon: View, DetailsIcon: View, CustomContent: View, Select
             .tint(.compound.iconAccentTertiary)
             .foregroundStyle(isEnabled ? .compound.textPrimary : .compound.textDisabled)
             .listRowInsets(ListRowPadding.textFieldInsets)
+            // The title is used as the placeholder, which VoiceOver only reads while empty.
+            .accessibilityLabel(label.title ?? "")
         case .secureField(let text):
             SecureField(text: text) {
                 Text(label.title ?? "")
@@ -147,6 +149,7 @@ public struct ListRow<Icon: View, DetailsIcon: View, CustomContent: View, Select
             .tint(.compound.iconAccentTertiary)
             .foregroundStyle(isEnabled ? .compound.textPrimary : .compound.textDisabled)
             .listRowInsets(ListRowPadding.textFieldInsets)
+            .accessibilityLabel(label.title ?? "")
             
         case .custom(let content):
             content()