Room details: improve members count UX (#1050)

* Inject user id into room’s details

* Refactor member fetch logic in RoomDetailsScreenViewModel

* Refactor DI

* Fetch members in RoomMembersListScreenViewModel

* Fetch members in InviteUsersScreen

* Use joinedMembersCount in room members list

* Cleanup

* Limit members refresh

* Cleanup binding

* Fix UT build errors

* Fix RoomDetailsScreenViewModelTests

* Fix RoomMembersListScreenViewModelTests

* Fix UTs

* Fix RoomDetailsScreenUITests

* Refine RoomDetailsScreenViewModelTests

* Add roomProxy extension

* PR comments

* Refactor room’s counter to Int

* Improve updateMembers() performances

* Fix memory leaks

ElementX/Sources/Screens/RoomDetailsScreen/RoomDetailsScreenModels.swift

@@ -22,8 +22,8 @@ import UIKit
 // MARK: View model
 
 enum RoomDetailsScreenViewModelAction {
-    case requestMemberDetailsPresentation([RoomMemberProxyProtocol])
-    case requestInvitePeoplePresentation([RoomMemberProxyProtocol])
+    case requestMemberDetailsPresentation
+    case requestInvitePeoplePresentation
     case leftRoom
     case requestEditDetailsPresentation(RoomMemberProxyProtocol)
 }
@@ -35,22 +35,18 @@ struct RoomDetailsScreenViewState: BindableState {
     let canonicalAlias: String?
     let isEncrypted: Bool
     let isDirect: Bool
+    let permalink: URL?
+
     var title = ""
     var topic: String?
     var avatarURL: URL?
-    let permalink: URL?
-    var members: [RoomMemberDetails] = []
-    var joinedMembersCount = 0
+    var joinedMembersCount: Int
     var isProcessingIgnoreRequest = false
     var canInviteUsers = false
     var canEditRoomName = false
     var canEditRoomTopic = false
     var canEditRoomAvatar = false
     
-    var isLoadingMembers: Bool {
-        members.isEmpty
-    }
-    
     var canEdit: Bool {
         !isDirect && (canEditRoomName || canEditRoomTopic || canEditRoomAvatar)
     }
@@ -62,10 +58,6 @@ struct RoomDetailsScreenViewState: BindableState {
     var bindings: RoomDetailsScreenViewStateBindings
 
     var dmRecipient: RoomMemberDetails?
-
-    private var isDMRoom: Bool {
-        isEncrypted && isDirect && members.count == 2
-    }
 }
 
 struct RoomDetailsScreenViewStateBindings {