Fixing Tests and deleting dead code (#2444)

ElementX/Sources/Services/Client/ClientProxy.swift

@@ -110,7 +110,7 @@ class ClientProxy: ClientProxyProtocol {
         
         clientQueue = .init(label: "ClientProxyQueue", attributes: .concurrent)
         
-        mediaLoader = MediaLoader(client: client, clientQueue: clientQueue)
+        mediaLoader = MediaLoader(client: client)
         
         notificationSettings = NotificationSettingsProxy(notificationSettings: client.getNotificationSettings(),
                                                          backgroundTaskService: backgroundTaskService)
@@ -159,15 +159,6 @@ class ClientProxy: ClientProxyProtocol {
         client.homeserver()
     }
 
-    var session: Session? {
-        do {
-            return try client.session()
-        } catch {
-            MXLog.error("Failed retrieving the client's session with error: \(error)")
-            return nil
-        }
-    }
-    
     private(set) lazy var pusherNotificationClientIdentifier: String? = {
         // NOTE: The result is stored as part of the restoration token. Any changes
         // here would require a migration to correctly match incoming notifications.

ElementX/Sources/Services/Client/ClientProxyProtocol.swift

@@ -78,9 +78,7 @@ protocol ClientProxyProtocol: AnyObject, MediaLoaderProtocol {
     var deviceID: String? { get }
 
     var homeserver: String { get }
-    
-    var session: Session? { get }
-    
+        
     var userDisplayName: CurrentValuePublisher<String?, Never> { get }
 
     var userAvatarURL: CurrentValuePublisher<URL?, Never> { get }

ElementX/Sources/Services/Client/MockClientProxy.swift

@@ -26,7 +26,6 @@ class MockClientProxy: ClientProxyProtocol {
     let userID: String
     let deviceID: String?
     let homeserver = ""
-    let session: Session? = nil
     let pusherNotificationClientIdentifier: String? = nil
     
     var roomSummaryProvider: RoomSummaryProviderProtocol? = MockRoomSummaryProvider()

ElementX/Sources/Services/Media/Provider/MediaLoader.swift

@@ -27,8 +27,7 @@ actor MediaLoader: MediaLoaderProtocol {
     private let client: ClientProtocol
     private var ongoingRequests = [MediaSourceProxy: MediaRequest]()
 
-    init(client: ClientProtocol,
-         clientQueue: DispatchQueue = .global()) {
+    init(client: ClientProtocol) {
         self.client = client
     }