From 6081a8fccf24466ef46ed7388cd3c5dfcaed375a Mon Sep 17 00:00:00 2001
From: Stefan Ceriu <stefanc@matrix.org>
Date: Tue, 19 Jul 2022 09:14:27 +0300
Subject: [PATCH] Prevent images cached on disk from loading on the main queue

---
 .../Services/Media/MediaProvider.swift        | 26 +++++++++++--------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/ElementX/Sources/Services/Media/MediaProvider.swift b/ElementX/Sources/Services/Media/MediaProvider.swift
index 86ad7e124..fc6b54b79 100644
--- a/ElementX/Sources/Services/Media/MediaProvider.swift
+++ b/ElementX/Sources/Services/Media/MediaProvider.swift
@@ -54,18 +54,12 @@ struct MediaProvider: MediaProviderProtocol {
             loadImageBgTask?.stop()
         }
         
-        let cachedImageLoadResult = await withCheckedContinuation { continuation in
-            imageCache.retrieveImage(forKey: source.underlyingSource.url()) { result in
-                continuation.resume(returning: result)
-            }
-        }
-        
-        if case let .success(cacheResult) = cachedImageLoadResult,
-           let image = cacheResult.image {
-            return .success(image)
-        }
-        
         return await Task.detached { () -> Result<UIImage, MediaProviderError> in
+            if case let .success(cacheResult) = await imageCache.retrieveImage(forKey: source.underlyingSource.url()),
+               let image = cacheResult.image {
+                return .success(image)
+            }
+            
             do {
                 let imageData = try clientProxy.loadMediaContentForSource(source.underlyingSource)
                 
@@ -85,3 +79,13 @@ struct MediaProvider: MediaProviderProtocol {
         .value
     }
 }
+
+private extension ImageCache {
+    func retrieveImage(forKey key: String) async -> Result<ImageCacheResult, KingfisherError> {
+        await withCheckedContinuation { continuation in
+            retrieveImage(forKey: key) { result in
+                continuation.resume(returning: result)
+            }
+        }
+    }
+}