ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-03 06:55:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Room mentioning in the composer (#3868)

Browse Source 
* refactored the suggestion item structure

to scale with the room pill

* Implemented a way for the rooms

to appear in the suggestions view for the RTE, however I need to add the pills to the composer and the compatibility with the plain text composer

* small code correction

* fix

* fixed a bug where the suggestion wasn't returning

the right suggestion type and the suggestion text properly

* implementation done!

also updated some tests, but we need more of them

* updated toolbar view model tests

* updated tests

* updated preview tests

* renamed the Avatars case for the suggestions
This commit is contained in:
Mauro
2025-03-06 11:32:37 +01:00
committed by GitHub
parent 2d77a1b10b
commit 5f59e867b5
43 changed files with 564 additions and 180 deletions
Download Patch File Download Diff File Expand all files Collapse all files
PreviewTests/Sources/__Snapshots__/PreviewTests/globalSearchScreen.iPad-en-GB-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:61ebfb0d15c41532a779c91b2ff490a7eb2daaeed9cbc8d9b804535e6d721758
size 158570
oid sha256:35951ab2ca021aacb1d40c8ae270efe23f47b38d0715b0475b93e0878300253d
size 163854
PreviewTests/Sources/__Snapshots__/PreviewTests/globalSearchScreen.iPad-pseudo-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:5bf11205a434cc0ff90b275e4475e86134ed15e861f21fb37f96a9fc3b25e262
size 158954
oid sha256:31ddb9be88bf2a6469fc8d3c8178170ca246b7c5429f9db98bb6f737cb282703
size 164238
PreviewTests/Sources/__Snapshots__/PreviewTests/globalSearchScreen.iPhone-16-en-GB-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:b0088c448b0a3e1106a869a747c7dc85c882c3a3553e529eb3e502ccbbb22e25
size 94620
oid sha256:8687afad034254066ea656378022ae61aed58cc2b2214edaf323ab13aded7c73
size 99720
PreviewTests/Sources/__Snapshots__/PreviewTests/globalSearchScreen.iPhone-16-pseudo-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:ba7e2d7a550a145a8f2872986b8eb6d437306390feaa2019329192c16398f642
size 94955
oid sha256:03d9f85d77b1e75bbc8ab40ce84756067a30d35d09a7ce6e821302ba35dbdece
size 100052
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.All-users-iPad-en-GB.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:e19ea504637c4aefa97fb4588c1731bb077fb825ba67fa4cfe1263722a9d13e2
size 80213
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.All-users-iPad-pseudo.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:dab315a14ac8d0214c38ed83b4dd618311b90340b7f3a5b0e53c25fb1a83f2de
size 80559
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.All-users-iPhone-16-en-GB.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:c4762b524a5d07f3dc8523b33ca2f724a48bf8c9c6153b317f74069e22870d8d
size 39035
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.All-users-iPhone-16-pseudo.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:c9c3c27bc47a307caee04d14dc733be9ed81407e9850012d351de55f75a84e40
size 40647
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.Room-iPad-en-GB.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:d4d9e70940d588b07861ad1439dae36303e298b020602e0f912c3cdd6a245fac
size 82208
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.Room-iPad-pseudo.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:d4d9e70940d588b07861ad1439dae36303e298b020602e0f912c3cdd6a245fac
size 82208
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.Room-iPhone-16-en-GB.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:098f483b0d38058c35128d0afc97984fd4ce8279bcc3be9f45accb709a0f5641
size 41394
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.Room-iPhone-16-pseudo.png
+3
View File
@@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:098f483b0d38058c35128d0afc97984fd4ce8279bcc3be9f45accb709a0f5641
size 41394
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.iPad-en-GB-0.png → PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.User-iPad-en-GB.png
View File
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.iPad-pseudo-0.png → PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.User-iPad-pseudo.png
View File
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.iPhone-16-en-GB-0.png → PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.User-iPhone-16-en-GB.png
View File
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.iPhone-16-pseudo-0.png → PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.User-iPhone-16-pseudo.png
View File
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.iPad-en-GB-1.png → PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.User-no-display-name-iPad-en-GB.png
View File
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.iPad-pseudo-1.png → PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.User-no-display-name-iPad-pseudo.png
View File
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.iPhone-16-en-GB-1.png → PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.User-no-display-name-iPhone-16-en-GB.png
View File
PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.iPhone-16-pseudo-1.png → PreviewTests/Sources/__Snapshots__/PreviewTests/mentionSuggestionItemView.User-no-display-name-iPhone-16-pseudo.png
View File
PreviewTests/Sources/__Snapshots__/PreviewTests/messageForwardingScreen.iPad-en-GB-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:9c92c6e353e7759adf0f75cf9a21297656c5c6daad3cfdbbf39301440b5bf8a0
size 159902
oid sha256:18a5a2705faf3823e0db694088206dc582621b4c52f31b7e5bdf5682889d5b94
size 165467
PreviewTests/Sources/__Snapshots__/PreviewTests/messageForwardingScreen.iPad-pseudo-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:dae65098eaf100bb2b762b5a25b4caa3a366e2780690e9a41a976d0bce707a74
size 161798
oid sha256:cae43b115dc17061874c1338042c62d71b0e41eebfee30e8c6e8c094490be64a
size 167363
PreviewTests/Sources/__Snapshots__/PreviewTests/messageForwardingScreen.iPhone-16-en-GB-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:bac9d7d51106483c23a118e85a567aafa466ba0a118eae797bd27e8f69d97417
size 108070
oid sha256:70ad8dc0e88cd46109fea561c0b7e220ca6bad6c7eb124d5b9f14b233f537820
size 112987
PreviewTests/Sources/__Snapshots__/PreviewTests/messageForwardingScreen.iPhone-16-pseudo-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:94508db7f079602a32529ba110fd027d9660c75c1d81f38a2e28a9448f12d5cc
size 107929
oid sha256:b2c4306135e1efa0552deddcaa09e22cae4f23687b0dcf840c9e39bad61635c0
size 112846
PreviewTests/Sources/__Snapshots__/PreviewTests/roomSelectionScreen.iPad-en-GB-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:29ecf5613971aad7c7890ed563d8b69d3c13ad1b2d9189c6cb3a80af53c6568b
size 156966
oid sha256:69544d0b3042e3997689f0131e87af191929ef1b62647b22b13bfe362307db1d
size 162531
PreviewTests/Sources/__Snapshots__/PreviewTests/roomSelectionScreen.iPad-pseudo-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:270c52cdad79a7495bded4560a8500f4b9266e0af8d3ec0742a42a2fd7c79888
size 158449
oid sha256:d224a0f3ea5243508744166a1ce4b635eeb4f08363e6c2558bf1ec2574ce8a1d
size 164014
PreviewTests/Sources/__Snapshots__/PreviewTests/roomSelectionScreen.iPhone-16-en-GB-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:429ace579d36361e16639266d2b14b6a515da57b14a25205c5e2460a1a8fe85e
size 105969
oid sha256:a995e503150a60c80666fba9135b70b3d21a59134ec400f8caf9bac3df16c54c
size 110886
PreviewTests/Sources/__Snapshots__/PreviewTests/roomSelectionScreen.iPhone-16-pseudo-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:f29a6ad8b2d81b1e3ffe1d9d8b526488d7c021bf17b04e74d8d3db38f2955944
size 107269
oid sha256:f5921b93c625428f436a43fec74d940a277d11fabbcf0e1412efbe574222101d
size 112186