ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-04 10:33:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a crash when the ClientProxy is freed. (#3090)

Browse Source
This commit is contained in:
Doug
2024-07-26 11:05:48 +01:00
committed by GitHub
parent 69ae36397b
commit 5a4d21ab7a
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Services/Client/ClientProxy.swift
+4 -1
View File
@@ -288,11 +288,14 @@ class ClientProxy: ClientProxyProtocol {
restartTask = nil restartTask = nil
} }
Task { // Capture the sync service strongly as this method is called on deinit and so the
// existence of self when the Task executes is questionable and would sometimes crash.
Task { [syncService] in
do { do {
defer { defer {
completion?() completion?()
} }
try await syncService?.stop() try await syncService?.stop()
} catch { } catch {
MXLog.error("Failed stopping the sync service with error: \(error)") MXLog.error("Failed stopping the sync service with error: \(error)")