In preparation of FTUE changes... (#2556)

* Remove the welcome screen

* Allow the UserSessionFlowCoordinator to control the whole app hierarchy, not only its splitView

* Start using the new verification state listener

* Rename Onboarding to AuthenticationStart in preparation for the new OnboardingFlowCoordinator; update snapshots and tests

* Make the AuthenticationCoordinator a proper FlowCoordinator

* Add some padding around the authentication start screen report a problem button

* Bump the RustSDK to v1.1.49

* Only add bottom padding on the authentication start screen report a problem button

UnitTests/Sources/AuthenticationStartScreenViewModelTests.swift

@@ -18,6 +18,6 @@ import XCTest
 
 @testable import ElementX
 
-class OnboardingScreenViewModelTests: XCTestCase {
+class AuthenticationStartScreenViewModelTests: XCTestCase {
     // Nothing to test, the view model has no mutable state.
 }

UnitTests/Sources/UserSession/UserSessionTests.swift

@@ -17,62 +17,4 @@ import Combine
 @testable import ElementX
 import XCTest
 
-final class UserSessionTests: XCTestCase {
-    var userSession: UserSession!
-    var clientProxy: ClientProxyMock!
-    let actionsPublisher = PassthroughSubject<ClientProxyAction, Never>()
-    
-    private var cancellables = Set<AnyCancellable>()
-    
-    override func setUpWithError() throws {
-        clientProxy = ClientProxyMock(.init(userID: "@test:user.net"))
-        clientProxy.actionsPublisher = actionsPublisher.eraseToAnyPublisher()
-        
-        cancellables.removeAll()
-        userSession = UserSession(clientProxy: clientProxy,
-                                  mediaProvider: MockMediaProvider(),
-                                  voiceMessageMediaManager: VoiceMessageMediaManagerMock())
-    }
-
-    func test_whenUserSessionReceivesSyncUpdateAndSessionControllerRetrievedAndSessionNotVerified_sessionVerificationNeededEventReceived() throws {
-        let expectation = expectation(description: "SessionVerificationNeeded expectation")
-        userSession.sessionSecurityStatePublisher.sink { securityState in
-            if securityState.verificationState == .unverified {
-                expectation.fulfill()
-            }
-        }
-        .store(in: &cancellables)
-        
-        let controller = SessionVerificationControllerProxyMock.configureMock(callbacks: PassthroughSubject<SessionVerificationControllerProxyCallback, Never>(),
-                                                                              isVerified: false,
-                                                                              requestDelay: .zero)
-
-        clientProxy.sessionVerificationControllerProxyReturnValue = .success(controller)
-        
-        actionsPublisher.send(.receivedSyncUpdate)
-
-        waitForExpectations(timeout: 1.0)
-    }
-    
-    func test_whenUserSessionReceivesSyncUpdateAndSessionIsVerified_didVerifySessionEventReceived() throws {
-        let expectation = expectation(description: "DidVerifySessionEvent expectation")
-        let controller = SessionVerificationControllerProxyMock.configureMock(callbacks: PassthroughSubject<SessionVerificationControllerProxyCallback, Never>(),
-                                                                              isVerified: false,
-                                                                              requestDelay: .zero)
-        clientProxy.sessionVerificationControllerProxyReturnValue = .success(controller)
-        
-        controller.callbacks.sink { value in
-            switch value {
-            case .finished:
-                expectation.fulfill()
-            default:
-                break
-            }
-        }
-        .store(in: &cancellables)
-        
-        actionsPublisher.send(.receivedSyncUpdate)
-        controller.callbacks.send(.finished)
-        waitForExpectations(timeout: 1.0)
-    }
-}
+final class UserSessionTests: XCTestCase { }

UnitTests/Sources/WelcomeScreenScreenViewModelTests.swift

@@ -1,22 +0,0 @@
-//
-// Copyright 2022 New Vector Ltd
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-//
-
-import XCTest
-
-@testable import ElementX
-
-@MainActor
-class WelcomeScreenScreenViewModelTests: XCTestCase { }