From 56d22104ad34b21f9dd57fe27d7c881278f13b7a Mon Sep 17 00:00:00 2001 From: Mauro Romito Date: Fri, 31 Jul 2026 16:45:11 +0200 Subject: [PATCH] fix some bugs: 1. caption being displayed when blank 2. gallery should be tapped even when scanning fails --- .../View/TimelineItemViews/GalleryItemTileView.swift | 5 +++-- .../Room/RoomSummary/RoomMessageEventStringBuilder.swift | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ElementX/Sources/Screens/Timeline/View/TimelineItemViews/GalleryItemTileView.swift b/ElementX/Sources/Screens/Timeline/View/TimelineItemViews/GalleryItemTileView.swift index 26fd01ad2..86f5304f7 100644 --- a/ElementX/Sources/Screens/Timeline/View/TimelineItemViews/GalleryItemTileView.swift +++ b/ElementX/Sources/Screens/Timeline/View/TimelineItemViews/GalleryItemTileView.swift @@ -32,8 +32,6 @@ struct GalleryItemTileView: View { videoOverlay } } - .contentShape(Rectangle()) - .onTapGesture { onTap() } .accessibilityElement(children: .ignore) .accessibilityLabel(item.filename) } scanningContent: { @@ -46,6 +44,9 @@ struct GalleryItemTileView: View { overflowOverlay } } + // Tappable in every scan state, so that an unsafe item can't hide the rest of the gallery. + .contentShape(Rectangle()) + .onTapGesture { onTap() } } @ViewBuilder diff --git a/ElementX/Sources/Services/Room/RoomSummary/RoomMessageEventStringBuilder.swift b/ElementX/Sources/Services/Room/RoomSummary/RoomMessageEventStringBuilder.swift index 98eaa7ff5..a315c1586 100644 --- a/ElementX/Sources/Services/Room/RoomSummary/RoomMessageEventStringBuilder.swift +++ b/ElementX/Sources/Services/Room/RoomSummary/RoomMessageEventStringBuilder.swift @@ -107,7 +107,7 @@ nonisolated struct RoomMessageEventStringBuilder { } private func buildMessage(for style: Style, caption: String?, type: String) -> AttributedString { - guard let caption else { + guard let caption, !caption.isBlank else { return AttributedString(type) }