Make the attachment menu an actual menu. (#2199)

There was a bug with the sheet/popover when overriding the colour scheme where the button renders in light mode when the app is in dark mode.

UITests/Sources/UserSessionScreenTests.swift

@@ -29,7 +29,7 @@ class UserSessionScreenTests: XCTestCase {
         try await Task.sleep(for: .seconds(1))
         try await app.assertScreenshot(.userSessionScreen, step: 2)
 
-        app.buttons[A11yIdentifiers.roomScreen.composerToolbar.openComposeOptions].tap()
+        app.buttons[A11yIdentifiers.roomScreen.composerToolbar.openComposeOptions].forceTap()
         try await app.assertScreenshot(.userSessionScreen, step: 3)
     }
 
@@ -52,7 +52,7 @@ class UserSessionScreenTests: XCTestCase {
         XCTAssert(app.staticTexts[firstRoomName].waitForExistence(timeout: 5.0))
         try await Task.sleep(for: .seconds(1))
 
-        app.buttons[A11yIdentifiers.roomScreen.composerToolbar.openComposeOptions].tap()
+        app.buttons[A11yIdentifiers.roomScreen.composerToolbar.openComposeOptions].forceTap()
         try await app.assertScreenshot(.userSessionScreenRTE, step: 1)
 
         app.buttons[A11yIdentifiers.roomScreen.attachmentPickerTextFormatting].tap()

UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.userSessionScreen-3.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:51572a32caa534f7da3120f69a8ab046e7f84c911a38bbfd714128364319a085
-size 512517
+oid sha256:aaefc3ed4e24c6efb98965c23b931566ad3e214df66beae06980d627078989a8
+size 676247

UITests/Sources/__Snapshots__/Application/en-GB-iPad-9th-generation.userSessionScreenRTE-1.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:c1218fb8e4cfab37f2013282aedc84081c48b067d64d06f5533e8d6f6f76b9a9
-size 520169
+oid sha256:6dd40677ed718698138d9ef21feae07c4474f6e77d179a69549004933c502f0f
+size 723856

UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.userSessionScreen-3.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:0fe47246cf49b033e4c47a3aa3aca3637d4023ed16affaf1338d3154b1cb2cbd
-size 283237
+oid sha256:8d81e5b309e74f8f5f37ea7d9929fae7ff54b3fd502eac1e5a5b322cc024cc98
+size 768968

UITests/Sources/__Snapshots__/Application/en-GB-iPhone-14.userSessionScreenRTE-1.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:b74b75ca3a65c7e17a188e7bb06730fe408518679f6f2a1d99026025305d3166
-size 276022
+oid sha256:5a796e2a7131226e3d1a6eca09f1f3c144f605bb2f85d863fd5483b2acd76d9c
+size 851474

UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.userSessionScreen-3.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:e1994a582d2cfe62b69d4665bb847ac3c4f796b4cc9f8bd83f6bb231f84566db
-size 505029
+oid sha256:d2a14abaf3a46bfd09368bea8e5f21c5f98d541fc9ddf77eb603237928a2f44a
+size 711656

UITests/Sources/__Snapshots__/Application/pseudo-iPad-9th-generation.userSessionScreenRTE-1.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:4b0e3e0f5368ac7e5c5563d5967f1dc224aedebe9b04d10141989ec8883922b6
-size 508387
+oid sha256:499cdf4bdbcef9f952c97cc519894100d5cf964254c31bfc7d9fceb67150eb18
+size 773160

UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.userSessionScreen-3.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:e55c79a65f37a3340c716e6f79d304f26772aaa9aebbdf6f404d45808fea55c0
-size 281966
+oid sha256:0e0de41f6bd8aa6e09e97fa346590e68c7dc320bed218dac22619e95ece787df
+size 829018

UITests/Sources/__Snapshots__/Application/pseudo-iPhone-14.userSessionScreenRTE-1.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:88f1c46520cc79be3b233a617af82b8ff88dbabf8ebd8ba441a1f5fd4d44857b
-size 284369
+oid sha256:468fb91896df309b60179b93f567c2bc9971dcb4d81514aa49d7a786f01704ab
+size 942085