ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-03 06:55:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove the event cache feature flag, it's enabled by default on the SDK and we haven't had any bug reports for it.

Browse Source
This commit is contained in:
Stefan Ceriu
2025-04-03 15:39:49 +03:00
parent 62636d8378
commit 5500cc2335
7 changed files with 4 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Application/AppSettings.swift
-5
View File
@@ -19,7 +19,6 @@ protocol CommonSettingsProtocol {
var enableOnlySignedDeviceIsolationMode: Bool { get }
var hideInviteAvatars: Bool { get }
var hideTimelineMedia: Bool { get }
var eventCacheEnabled: Bool { get }
}
/// Store Element specific app settings.
@@ -57,7 +56,6 @@ final class AppSettings {
case fuzzyRoomListSearchEnabled
case enableOnlySignedDeviceIsolationMode
case knockingEnabled
case eventCacheEnabledV2
}
private static var suiteName: String = InfoPlistReader.main.appGroupIdentifier
@@ -343,9 +341,6 @@ final class AppSettings {
@UserPreference(key: UserDefaultsKeys.hideTimelineMedia, defaultValue: false, storageType: .userDefaults(store))
var hideTimelineMedia
@UserPreference(key: UserDefaultsKeys.eventCacheEnabledV2, defaultValue: true, storageType: .userDefaults(store))
var eventCacheEnabled
}
extension AppSettings: CommonSettingsProtocol { }
ElementX/Sources/Other/Extensions/ClientBuilder.swift
+1 -3
View File
@@ -15,15 +15,13 @@ extension ClientBuilder {
slidingSync: ClientBuilderSlidingSync,
sessionDelegate: ClientSessionDelegate,
appHooks: AppHooks,
enableOnlySignedDeviceIsolationMode: Bool,
eventCacheEnabled: Bool) -> ClientBuilder {
enableOnlySignedDeviceIsolationMode: Bool) -> ClientBuilder {
var builder = ClientBuilder()
.crossProcessStoreLocksHolderName(holderName: InfoPlistReader.main.bundleIdentifier)
.enableOidcRefreshLock()
.setSessionDelegate(sessionDelegate: sessionDelegate)
.userAgent(userAgent: UserAgentBuilder.makeASCIIUserAgent())
.requestConfig(config: .init(retryLimit: 0, timeout: 30000, maxConcurrentRequests: nil, retryTimeout: nil))
.useEventCachePersistentStorage(value: eventCacheEnabled)
builder = switch slidingSync {
case .restored: builder
ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/DeveloperOptionsScreenModels.swift
-1
View File
@@ -44,7 +44,6 @@ protocol DeveloperOptionsProtocol: AnyObject {
var enableOnlySignedDeviceIsolationMode: Bool { get set }
var elementCallBaseURLOverride: URL? { get set }
var knockingEnabled: Bool { get set }
var eventCacheEnabled: Bool { get set }
}
extension AppSettings: DeveloperOptionsProtocol { }
ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/View/DeveloperOptionsScreen.swift
+1 -10
View File
@@ -30,16 +30,7 @@ struct DeveloperOptionsScreen: View {
}
}
}
Section("General") {
Toggle(isOn: $context.eventCacheEnabled) {
Text("Event cache")
}
.onChange(of: context.eventCacheEnabled) {
context.send(viewAction: .clearCache)
}
}
Section("Room List") {
Toggle(isOn: $context.publicSearchEnabled) {
Text("Public search")
ElementX/Sources/Services/Authentication/AuthenticationClientBuilder.swift
+1 -2
View File
@@ -48,8 +48,7 @@ struct AuthenticationClientBuilder: AuthenticationClientBuilderProtocol {
slidingSync: .discover,
sessionDelegate: clientSessionDelegate,
appHooks: appHooks,
enableOnlySignedDeviceIsolationMode: appSettings.enableOnlySignedDeviceIsolationMode,
eventCacheEnabled: appSettings.eventCacheEnabled)
enableOnlySignedDeviceIsolationMode: appSettings.enableOnlySignedDeviceIsolationMode)
.sessionPaths(dataPath: sessionDirectories.dataPath,
cachePath: sessionDirectories.cachePath)
.sessionPassphrase(passphrase: passphrase)
ElementX/Sources/Services/UserSession/UserSessionStore.swift
+1 -2
View File
@@ -123,8 +123,7 @@ class UserSessionStore: UserSessionStoreProtocol {
slidingSync: .restored,
sessionDelegate: keychainController,
appHooks: appHooks,
enableOnlySignedDeviceIsolationMode: appSettings.enableOnlySignedDeviceIsolationMode,
eventCacheEnabled: appSettings.eventCacheEnabled)
enableOnlySignedDeviceIsolationMode: appSettings.enableOnlySignedDeviceIsolationMode)
.sessionPaths(dataPath: credentials.restorationToken.sessionDirectories.dataPath,
cachePath: credentials.restorationToken.sessionDirectories.cachePath)
.username(username: credentials.userID)