always call tear down (#1909)

UnitTests/Sources/AnalyticsSettingsScreenViewModelTests.swift

@@ -25,7 +25,7 @@ class AnalyticsSettingsScreenViewModelTests: XCTestCase {
     private var context: AnalyticsSettingsScreenViewModelType.Context!
     
     override func tearDown() {
-        appSettings.analyticsConsentState = .unknown
+        AppSettings.reset()
     }
     
     @MainActor override func setUpWithError() throws {

UnitTests/Sources/AnalyticsTests.swift

@@ -37,6 +37,10 @@ class AnalyticsTests: XCTestCase {
                                                                    bugReportService: ServiceLocator.shared.bugReportService))
     }
     
+    override func tearDown() {
+        AppSettings.reset()
+    }
+    
     func testAnalyticsPromptNewUser() {
         // Given a fresh install of the app (without PostHog analytics having been set).
         // When the user is prompted for analytics.

UnitTests/Sources/ComposerToolbarViewModelTests.swift

@@ -42,6 +42,10 @@ class ComposerToolbarViewModelTests: XCTestCase {
                                              mentionDisplayHelper: ComposerMentionDisplayHelper.mock)
     }
     
+    override func tearDown() {
+        AppSettings.reset()
+    }
+
     func testComposerFocus() {
         viewModel.process(roomAction: .setMode(mode: .edit(originalItemId: TimelineItemIdentifier(timelineID: "mock"))))
         XCTAssertTrue(viewModel.state.bindings.composerFocused)