Mark rooms as read on push and pop. (#462)

We don't have visibility into timeline item read status so can't do this continuously yet.

* Simplify RoomTimelineProvider's responsibilities.

ElementX/Sources/Screens/RoomScreen/RoomScreenCoordinator.swift

@@ -64,6 +64,7 @@ final class RoomScreenCoordinator: CoordinatorProtocol {
     }
     
     func stop() {
+        viewModel?.context.send(viewAction: .markRoomAsRead)
         viewModel?.stop()
         viewModel = nil
         parameters = nil
@@ -106,7 +107,7 @@ final class RoomScreenCoordinator: CoordinatorProtocol {
                 MXLog.debug("Selected \(emoji) for \(itemId)")
                 self?.navigationStackCoordinator.setSheetCoordinator(nil)
                 Task {
-                    await timelineController.sendReaction(emoji, for: itemId)
+                    await timelineController.sendReaction(emoji, to: itemId)
                 }
             case .dismiss:
                 self?.navigationStackCoordinator.setSheetCoordinator(nil)

ElementX/Sources/Screens/RoomScreen/RoomScreenModels.swift

@@ -42,6 +42,8 @@ enum RoomScreenViewAction {
     case sendReaction(key: String, eventID: String)
     case cancelReply
     case cancelEdit
+    /// Mark the entire room as read - this is heavy handed as a starting point for now.
+    case markRoomAsRead
 }
 
 struct RoomScreenViewState: BindableState {

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift

@@ -41,7 +41,7 @@ class RoomScreenViewModel: RoomScreenViewModelType, RoomScreenViewModelProtocol
         self.timelineViewFactory = timelineViewFactory
         self.mediaProvider = mediaProvider
         
-        super.init(initialViewState: RoomScreenViewState(roomId: timelineController.roomId,
+        super.init(initialViewState: RoomScreenViewState(roomId: timelineController.roomID,
                                                          roomTitle: roomName ?? "Unknown room 💥",
                                                          roomAvatar: nil,
                                                          bindings: .init(composerText: "", composerFocused: false)))
@@ -109,13 +109,16 @@ class RoomScreenViewModel: RoomScreenViewModelType, RoomScreenViewModelProtocol
         case .sendMessage:
             await sendCurrentMessage()
         case .sendReaction(let emoji, let itemId):
-            await timelineController.sendReaction(emoji, for: itemId)
+            await timelineController.sendReaction(emoji, to: itemId)
         case .displayEmojiPicker(let itemId):
             callback?(.displayEmojiPicker(itemId: itemId))
         case .cancelReply:
             state.composerMode = .default
         case .cancelEdit:
             state.composerMode = .default
+            state.bindings.composerText = ""
+        case .markRoomAsRead:
+            await markRoomAsRead()
         }
     }
 
@@ -134,6 +137,10 @@ class RoomScreenViewModel: RoomScreenViewModelType, RoomScreenViewModelProtocol
             break
         }
     }
+    
+    private func markRoomAsRead() async {
+        _ = await timelineController.markRoomAsRead()
+    }
 
     private func itemTapped(with itemId: String) async {
         state.showLoading = true
@@ -171,9 +178,9 @@ class RoomScreenViewModel: RoomScreenViewModelType, RoomScreenViewModelProtocol
 
         switch currentComposerState {
         case .reply(let itemId, _):
-            await timelineController.sendReply(currentMessage, to: itemId)
+            await timelineController.sendMessage(currentMessage, inReplyTo: itemId)
         case .edit(let originalItemId):
-            await timelineController.editMessage(currentMessage, of: originalItemId)
+            await timelineController.editMessage(currentMessage, original: originalItemId)
         default:
             await timelineController.sendMessage(currentMessage)
         }
@@ -250,7 +257,7 @@ class RoomScreenViewModel: RoomScreenViewModelType, RoomScreenViewModelProtocol
             state.bindings.composerText = "> \(item.text)"
         case .copyPermalink:
             do {
-                let permalink = try PermalinkBuilder.permalinkTo(eventIdentifier: item.id, roomIdentifier: timelineController.roomId)
+                let permalink = try PermalinkBuilder.permalinkTo(eventIdentifier: item.id, roomIdentifier: timelineController.roomID)
                 UIPasteboard.general.url = permalink
             } catch {
                 displayError(.alert(ElementL10n.roomTimelinePermalinkCreationFailure))
@@ -263,12 +270,12 @@ class RoomScreenViewModel: RoomScreenViewModelType, RoomScreenViewModelProtocol
             state.bindings.composerFocused = true
             state.composerMode = .reply(id: item.id, displayName: item.sender.displayName ?? item.sender.id)
         case .viewSource:
-            let debugDescription = timelineController.debugDescriptionFor(item.id)
+            let debugDescription = timelineController.debugDescription(for: item.id)
             MXLog.info(debugDescription)
             state.bindings.debugInfo = .init(title: "Timeline item", content: debugDescription)
         case .retryDecryption(let sessionId):
             Task {
-                await timelineController.retryDecryption(forSessionId: sessionId)
+                await timelineController.retryDecryption(for: sessionId)
             }
         }
         

ElementX/Sources/Screens/RoomScreen/View/RoomScreen.swift

@@ -29,6 +29,13 @@ struct RoomScreen: View {
             .overlay { loadingIndicator }
             .alert(item: $context.alertInfo) { $0.alert }
             .sheet(item: $context.debugInfo) { DebugScreen(info: $0) }
+            .task {
+                // Give a couple of seconds for items to load and to see them.
+                try? await Task.sleep(for: .seconds(2))
+                
+                guard !Task.isCancelled else { return }
+                context.send(viewAction: .markRoomAsRead)
+            }
     }
     
     var timeline: some View {