Create & Join rooms UI/UX tweaks (#1005)

* Fix people icon size

* Disable dismiss when loading in StartChatScreen

* Reduce debounce on search

* Add padding to invite button

* Add show/hide bottom bar behaviour

* Fix bg color in StartChatScreen form

* Update localisations

* Update search users results to 10

* Fix form background in InviteUsersScreen

* Fix invites list bg color

* Add mxid in InvitesScreenCell

* Refactor InvitesScreenCell design

* Fix separator spacing

* Add more design fixes

* Refine InvitesScreenCell layout

* Refactor UserProfileCell design

* Refactor FormRowAccessory

* Update localisations

* Fix camera size and security section padding

* Change create button style

* Refine InviteUsersScreenSelectedItem

* Refine CreateRoomScreen

* Refine UserProfileCell padding

* Amend preview name

* delete test code

* Add separator in security section

* Fix spacing in InviteUsersScreenSelectedItem

* Revert confirmationAction in CreateRoomScreen

* Refine HomeScreenInvitesButton

* Add dismiss keyboard in InviteUsersScreen

* Refactor FormRowAccessory

* Remove isDisabled from FormButtonStyles

* Update localisations

* Cleanup RoomDetailsEditScreen

* UI fixes on horizontal user carousel

* Refactor InviteUsersScreenSelectedItem

* Try fix flaky tests

* Fix typo

* Update snapshot tests

* Fix flaky UTs

* Fix HomeScreen ui tests

* Fix scroll on selection

* Refactor RoomFlowCoordinatorTests
This commit is contained in:
Alfonso Grillo
2023-06-06 10:03:38 +02:00
committed by GitHub
parent fedd401a56
commit 4e926c3334
87 changed files with 484 additions and 315 deletions
@@ -36,6 +36,7 @@ class CreateRoomScreenUITests: XCTestCase {
// repeat the same letter enough times to avoid that but also to work on iPads
app.textFields[A11yIdentifiers.createRoomScreen.roomName].tap()
app.textFields[A11yIdentifiers.createRoomScreen.roomName].typeText(.init(repeating: "x", count: 200))
app.textFields[A11yIdentifiers.createRoomScreen.roomName].typeText("\n")
try await app.assertScreenshot(.createRoom, step: 1)
}
+1 -1
View File
@@ -20,7 +20,7 @@ import XCTest
class HomeScreenUITests: XCTestCase {
func testInitialStateComponents() async throws {
let app = Application.launch(.home)
// The gradient of the skeleton canges dynamically over time so the time may influence the match, better to have a lower precision for this one
// The gradient of the skeleton changes dynamically over time so the time may influence the match, better to have a lower precision for this one
try await app.assertScreenshot(.home)
}
}
+2 -2
View File
@@ -27,7 +27,7 @@ class StartChatScreenUITests: XCTestCase {
func testSearchWithNoResults() async throws {
let app = Application.launch(.startChat)
let searchField = app.searchFields.firstMatch
searchField.clearAndTypeText("None")
searchField.clearAndTypeText("None\n")
XCTAssert(app.staticTexts[A11yIdentifiers.startChatScreen.searchNoResults].waitForExistence(timeout: 1.0))
try await app.assertScreenshot(.startChat, step: 1)
}
@@ -35,7 +35,7 @@ class StartChatScreenUITests: XCTestCase {
func testSearchWithResults() async throws {
let app = Application.launch(.startChatWithSearchResults)
let searchField = app.searchFields.firstMatch
searchField.clearAndTypeText("Bob")
searchField.clearAndTypeText("Bob\n")
XCTAssertFalse(app.staticTexts[A11yIdentifiers.startChatScreen.searchNoResults].waitForExistence(timeout: 1.0))
XCTAssertEqual(app.collectionViews.firstMatch.cells.count, 2)
try await app.assertScreenshot(.startChat, step: 2)
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:baaa8f3c90cfd2c3fee4aaf643c5d878ac7ad0985f69b26f6f4d4626f721dc0f
size 209068
oid sha256:b98c8f285e897db8750b1a9c2623dff83657ccac78c92026694ab951fe97370d
size 132704
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:263b659ad21fc364a91162eb0aea523a1cc0db497580ec10377b78f3b9425ed6
size 142198
oid sha256:7bbe9ac53bda18e3ddf5d78719e05dc96e45b7ec9e7647a39af8e0f195df22d6
size 134878
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:b3bcc5ad6895274acbc571fed907c519adb3fbf8af9d24483e5e7ab787ceafee
size 119395
oid sha256:a1fc3bedc93e98a70960100bed7b7e42d75f527bac704a9ab2b911a706b2f306
size 114079
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:c3909142865f334588ac1b1e9dfeb6e3b9ef44c8ad715dfab676f2cb4ea20a7c
size 108716
oid sha256:165c81b9279ee7bead62d0d4ffe0bad27a35ffc6ff9d5222315a6ffd6ecafe61
size 109543
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:0126c1cec30da2fb2dd10aa03713ae73cc65e19a14482ce2bd3f6ce51f74ab9c
size 98972
oid sha256:8ad83846a13b9f605e7d356b04c12e17a68ea0d82bfb734f6c5b6e62dd06c25e
size 99723
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:12053c27263fb18bdacfa18a6950ed14f94db58ad54cff05c4853d84e092a929
size 108772
oid sha256:f682e61fc6d92c8e552616f51b324472fca2cc63592279c21a6d1a7bfd710eda
size 109561
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:6047011ae61868f6d4ddce792dcdc41ed98ea22f277823de9e65a7f3336481d5
size 97139
oid sha256:4422f5921e33b1934089c713a7ba01f9f1df6f47e49b35f4e79727c0f95fc8c3
size 98044
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:eceabc10203dde514204abb2e9f842ec10f18ca0216c5932bda372ec8ee727a5
size 188129
oid sha256:8a3aaffcbf38b6ddcde6142634a2803705a2d8438a8e2cceb2c8f567ecc1ca9f
size 191803
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:11505b76e0455ca673ccd716893e2fe771e34666dcedacbf998bc5c3d0a550ec
size 98629
oid sha256:3bddd4f90e40d59491c39cbc38c6231d65ac245dc82b3de5c9103c5e631018a5
size 102257
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:0f23e94a8e39bc7adaa06136aea223b6112626f77425ff3db021c5496bff3f28
size 98983
oid sha256:f11dd1f578ae2940dae840b3960ad0f67e512f93529270836555935559046720
size 102629
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:3f1c4b2bd06eca5a87809115c557c2bd56aa932d0d3beeadabea1151ca908a49
size 78981
oid sha256:26fd68190524bd5783049cc5e2bde16b447e66aa385d3a2d8515f9191413d0b6
size 78813
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:ae566dbc1b03a1cfdb1b3b1412c79c2b0801b3f60f89180d60be7f8819782449
size 75125
oid sha256:0075eca03efdacb62b8531ad03987ce3ce967ece23ff44a2254ba91f700968bd
size 75117
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:2576f456ae6a5e10d7df17031c1487a3607492533d4e9a64620fe186e8eacb8d
size 136466
oid sha256:bed7e7bb223fe28b12880d4b630e1e0226d75a1fcc36cd0d9bdb9c64b940bf7e
size 76764
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:4cc5da4209e2b62cfd938b8a9c47c3bf59fe07eb8dcde1ad73b7f7ea9498f56c
size 151050
oid sha256:5b82364f1fdda5b86cdea790ae4a05dfd5f03a72f2ab462f78020db43e39615f
size 88969
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:0ab1b76232611d7689f41a08377cab9602f358107922d36618fe547ddb34f523
size 109825
oid sha256:fcfa75205684ebf75efa0a6c2a18f044d0a039aad0c4b6d9fe02b3a2faebcc8a
size 108859
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:bc1b97579497bc0dd6cbd72f11b09a1ef50508baea8871f34f3f64b512652ffd
size 202796
oid sha256:6292feb05252ba017f063f455eeee30d9a48ded0a2e74dc486e78675db5bf31a
size 173094
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:924992e12a0c4c25f20c9bd7d79388ad0640cbba7bd0d0bd1fba2c58e1d7e025
size 184886
oid sha256:582e1c2a98c6cb08637f1329bcd119e4abd8aaf1e177a738dd781bb015ab2f83
size 178558
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:4cd0921da82ea2a1ee28bfe36c98ef62128e49f9f2244966f45f80d46512f512
size 156826
oid sha256:4e5a3b21c2b5370186f1a6868606456e980c0e8f170985a46fcc466406d6d667
size 149682
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:2845c3bdf17835c7d25fb5f40b7c8f2e71f7ecf12dd739599b7935a24d7bd425
size 130104
oid sha256:00f38866c3f3810463005c6ed775a08d76b7486da55a1328ad3bd38a04a4210d
size 131831
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:51b7109da2b03924f3a476d1be83b2b35c7f494839cb9509bd9f8cc2ee7600d2
size 113342
oid sha256:488837d7e8fb28268dc66505211d0bd91dd6715dadbcd5f81df50bda52becb8b
size 117214
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:8a92d04655f2c51f2c595d359d7c0b75b47018a17e2ca82f2063b20be6cb737a
size 132541
oid sha256:a4a6fcf1c1e28e5386a31491f0211996abcaed1b3351ad492e4664a5972b6196
size 131917
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:e0e8a9421366b6cfc72443ab9d7ee96ffe0b81ada3cd7ed48b911fae4cccf845
size 112719
oid sha256:155cce8a7b5c98e5e8733207ed8a0d38b0ad039d4bcad7573692fc43c857bb4c
size 114647
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:85e5dfea417d1130ed453e1c483034b2e1f717a1418b164a4f9856bfe5a175fc
size 353862
oid sha256:9aa494529eacf68fb164344ea79df97c18b9c2018952e6d4c89ee43969ed5864
size 359486
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:7cebc6d0ae1b65debda82b586a4033d83a5c21e9d125855c8544ac70631aaee3
size 112839
oid sha256:0624e010476e83da7d3af40c0119aef50ff3f1cc0b4e17aa1a23a10cad2fdecf
size 121285
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:a0cdb8a004a3ca661aae6a649fdbdd0c8990f6bcc8760cf222b05490a7785fa7
size 114708
oid sha256:78a8161f388f6219e397f0edc692f89cd6c047eb8200a0e87800cbf98dfdf1ed
size 121788
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:0410d0f1a5b47c01c7fa4349c8aa10ee9a41e7fc550621ca6f10e8b1dc9e099a
size 87208
oid sha256:592e556366f2e641b90b6fa7781e60d2e20ae49ff22941217c762ed1d985b4f0
size 89084
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:4916268dcb63398ae44654dc5f98386102d0c9b3516fedfd75a6868dc7d77a1b
size 79861
oid sha256:17829e2bba60490c2c7f407ea76ef165604f58688accd9e651605439e6152801
size 79726
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:edcf7669efe5e3e0124de8b15bb0e7d12705f534a54ee2bbc7b6d6577fc15be2
size 173595
oid sha256:f10b8116c8cb3b3a10f40801d20ce13e82601d4797d52cf24b6c823a8048286d
size 91095
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:130c4c3c1e6fc4b872ab1dff2c728bb90ffe695490ddebed3efd261d8900931a
size 193286
oid sha256:8815bab7cae82e1a4e909e77a0a3d238fefd805d23c95f4382b881a29098ac39
size 113070
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:c695db4e372c07c4f0b054673fab92138dbcbb14acf17dcd94541cd67d793ea1
size 133816
oid sha256:dd2edd16664559d36dad411cb91f3e8e0c900bee0cec0a705d38f1ed56c21e10
size 131842
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:22d07df302e6dc102265be2fa731733c0c78f74520c94822fc09ccedbf9f14c9
size 235617
oid sha256:fad59c0ede5e2149e11acca6b0aa8b2520663625305e2c36d36be3ece5603f14
size 155345
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:1d48027b7f07bd8e88e1f4b396ce6cfe72575c7c69cf53409318cad60fa5c31b
size 170726
oid sha256:bb8945c748b19041383905c2b7d95635e5c4a5f17fc76c5e914d1fb0ad3c5f16
size 158543
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:5a3044792fc93c2b662b03ffe34d4fcd386547196fa6e06417006d406845d011
size 148728
oid sha256:884862e412e1092149c570be27622dc162d74a0cb81d05481bb2467ed158f908
size 136386
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:0763b757551c435ecd922bdee878d617d5760c74d81a3c0a9138e64495affea8
size 111446
oid sha256:dd65d281319ced39cb030be3d30a696563199a64c409fa5408f2bb63e17c88a4
size 112846
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:f2ceb1f749349fbf41e5fabb7dfd3e7daf5adb47dfb35810bd0f9ed01c8bdc98
size 102368
oid sha256:e70e0b6f6479e63e617901129e6ece9b44e3cefe2749c4dc45118dfa3e09cdda
size 103953
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:343d749a7294d6acd559e2425a704225368adab14553aada095cac8ea94c499a
size 111617
oid sha256:a36ca04a3fd8f6986b681cfb1225b8a5718f07993f243e8d5dca2ca2dc932b56
size 113042
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:6b14407efd99162bdd2ad4b859896cdf11b8bf98fc3522e85ae399e909f39c22
size 103057
oid sha256:bfc1198cac4e564e4e16893ef63d40f69821509b999ea1a056bcce828c63d5e3
size 105787
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:2b33ca3e65d765ae24b1a0223198e7b42ed0686a825629f5b0f8bc93b357d6b3
size 233512
oid sha256:6d542cd3da60962a5448e535588017cad7d32165a2cae24582f6fb8d2774ad7f
size 236437
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:1ecf3a404f38c4c4fa376c236e50a1160f4d6eadbcd77145f156a81cec245e12
size 104268
oid sha256:36902da1fec889dfd9f25d478700a369c53a7887463cecdcf6b4fb59df983003
size 107261
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:161305b820d23a1e29a5d80f1a4a306c68a65af933d039dcd50f49d888a1f552
size 104655
oid sha256:f0eb1c140b180a447c7dd05e39b6f1b79996a11f9e639813c582a22defd8d750
size 107639
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:95180272e203386363518550eaca4ab66a5362a3514e8046b72e2d5010380fab
size 81651
oid sha256:46415f67c771fd4427df70d597c91949acfe8febd255e6913dc9ae6565240944
size 81364
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:dff46af4fb867cfe29c989b5c0e4c3ec7db25f2af19ca60e4ea075f65ac719ce
size 78457
oid sha256:b779f2fee144be2ffde89974a6eab6d0dec18c972e21f9453c00a581dec395fd
size 78284
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:59084649c92cd9450f10cd3c36e6f349eb1c6ae118bdbe3e00c0538ef6e4007b
size 137037
oid sha256:f7c664b920004d7aab3c699e22db994fc22d711ab651569745a4cf95bb2626dc
size 79869
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:eb5e31e230afc158c1a8c2de86a34f909bb27e4c42eee5b1b840b397ed5db275
size 152584
oid sha256:c71f306d56b74a008048a7181ed105db4c055756b023064e887606c8739beee1
size 92172
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:5ee809d18954f64b7376887a323297c66e6a639b2fb004385eb8143d692bd604
size 114129
oid sha256:ad71830118395e8553974306ab68cb3cc31951193a0cd209e22f3930b81007e8
size 113453
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:652b2de02c2c6e22728d980a9fb2e30408c9e67f556e1771e186167e05bc8b8f
size 215886
oid sha256:fd74a679802a11fcc2b43138acdb49aede21aaf56f852acaff5032e718e92aec
size 219285
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:104762372501a72e46b0c277f803208588c6da3cb3cf2693aacf34673ce0dee1
size 237256
oid sha256:a3e7c958e56948c7e69c1b5d7f1fbf4ad6c970494e717ea8e67846f383cc2b0c
size 225672
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:64e4e2e86430c86983f21b71d0ec153ee2f7ee9edd15f4865c3f5f55b7dd285f
size 219197
oid sha256:3261ec264fccba89811841b001e912520ffe86eca1517e4a62bdad97f371ea70
size 196194
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:d08b47a4b95215b19063f50561cf6d9ed70c2ee3d811896b32f18fb5eaa715c3
size 136471
oid sha256:1d59d603e4b5ebf5f595473f0fd4141935bc05d440d4bdc83ab59abf9f330ef9
size 137894
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:3def893c8b3107f5382c260d5643f2229e23a738b73c94ec4f55d63e1353ca1b
size 117552
oid sha256:7cf8afe28c88f19e2eeeacabcdda97dce7508aa4ca86cf1c97cbffaadbafb06c
size 120558
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:51c9ca1cd193dd47c68c75adfc1d0e0f58c1f95b2ab55135f4cc7d815ecd3c0e
size 136285
oid sha256:41361e31931f7b2148193157c3b215e255d37a52829d86b71a81d4bef8bc853e
size 137234
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:c5e5a6fec62819bf6f74d4beab057fe78de8f3205f87a108e3593f235bc55948
size 120091
oid sha256:7ff0c839e01431065ce8b6d360d1eb6eaf0bed9711cc65f37dcbee9354d8faf6
size 118430
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:ef8a8fe4a9ae1bdd437a2618574962d1c57175e1893131293d6fa13f9a9dd1c1
size 522278
oid sha256:faec25c167db1f2e972af19945822ad6700b0d049bad575e996c1ff19e87a21c
size 527282
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:dc43c5d83a75af17a28421ffed097f67d1ffc026b8d0d36c5cae1f4a1c012336
size 137190
oid sha256:4cd0a9237375a40dfb0103869c8c3613e4641f69bbdb66541c180614af4dd9f6
size 147939
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:7de304c4383db02fde81ede2169907a2394c27dd49a1238fb91626f110d44b3f
size 137714
oid sha256:7a505964d2db2ca2aa32e6ffc4534fdd46150bd857fd25986863fe3ee9f6f72d
size 148426
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:2f2e6eb2365ccd1c1a0ace52872a8e84f191736dd7b74c7898256c420e30fe73
size 90556
oid sha256:5af45df522a03e9d181e645ff1c02fc2de8a5c85e4adc630a627e737e1a73b81
size 92003
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:232a667d2fd91bd1746509b186db7eb9676a4732110a84e3c9543808abf1d2f5
size 82817
oid sha256:cf607207533190eec6d025525d94af8c9531132c1459eb8b5ca98e899ea22108
size 84390
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:968b785eb407bd7ef81eae302508f8e81166e2ab3a3c5226d6886840ee2cefbb
size 145486
oid sha256:2769d12441a0c98f7ef2030ed3a60615fa77d86b8281bb2543b3b546332eab4c
size 92958
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:6742804364719e4bb519d0f04a07ae6b7f9f06cf3e9ae994aef0e184d40cbcda
size 167718
oid sha256:7c7a5833443554ba94d968d95f636566fa7c5730de97af9f006c6281977a9ba8
size 115013
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:aba080e7925f3d3cc9593509e6ba183b9e31a8a7ec7da4d7d574e35f192678a1
size 140952
oid sha256:2d3881b83f72809c29c370c6da8cc37bc496869e3dc976a2d8cf775f512242fe
size 140966