Room member details cleanup (#452)

* Fixes #421 - Stop loading room members twice for displaying the members screen * Rename RoomMembers to RoomMemberDetails throughout * Add changelog
2026-11-03 06:55:59 +00:00 · 2023-01-17 09:31:53 +02:00
parent 1b9d1fedf1
commit 4b56e4af73
15 changed files with 113 additions and 132 deletions
@@ -0,0 +1,66 @@
+//
+// Copyright 2022 New Vector Ltd
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
+import SwiftUI
+
+typealias RoomMemberDetailsViewModelType = StateStoreViewModel<RoomMemberDetailsViewState, RoomMemberDetailsViewAction>
+
+class RoomMemberDetailsViewModel: RoomMemberDetailsViewModelType, RoomMemberDetailsViewModelProtocol {
+    private let mediaProvider: MediaProviderProtocol
+    
+    var callback: ((RoomMemberDetailsViewModelAction) -> Void)?
+
+    init(mediaProvider: MediaProviderProtocol,
+         members: [RoomMemberProxy]) {
+        self.mediaProvider = mediaProvider
+        super.init(initialViewState: .init(members: members.map { RoomDetailsMember(withProxy: $0) },
+                                           bindings: .init()))
+    }
+    
+    // MARK: - Public
+    
+    override func process(viewAction: RoomMemberDetailsViewAction) async {
+        switch viewAction {
+        case .selectMember(let id):
+            MXLog.debug("Member selected: \(id)")
+        case .loadMemberData(let id):
+            await loadAvatar(forMember: id)
+        }
+    }
+
+    private func loadAvatar(forMember memberId: String) async {
+        guard let member = state.members.first(where: { $0.id == memberId }) else {
+            return
+        }
+        if member.avatar != nil {
+            // already loaded
+            return
+        }
+        guard let avatarUrl = member.avatarUrl else {
+            // user has no avatar
+            return
+        }
+
+        switch await mediaProvider.loadImageFromURLString(avatarUrl, avatarSize: .user(on: .roomDetails)) {
+        case .success(let image):
+            if let index = state.members.firstIndex(where: { $0.id == memberId }) {
+                state.members[index].avatar = image
+            }
+        case .failure(let error):
+            MXLog.debug("Failed to retrieve room member avatar: \(error)")
+        }
+    }
+}