ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-03 06:55:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes vector-im/element-x-ios/issues/117 - Event permalink timeline action

Browse Source 
* moved NSRegularExpression outside of the AttributedString builder into the MatrixEntityRegex
* fixed eventId v3 regex
* added permalink builders for users, room identifiers and aliases, and events
* added timeline item permalink contextual menu actions and error alerts
* added an app wide ServiceLocator and moved the top level userIndicatorPresenter to it.
* added URL constructor that takes a StaticString and returns an non-optional
* Include Unit and UI tests in the swiftlint search paths
This commit is contained in:
Stefan Ceriu
2022-09-12 21:34:53 +03:00
committed by GitHub
parent 4006cc6b80
commit 4660f096f8
25 changed files with 414 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files
UnitTests/Sources/AttributedStringBuilderTests.swift
+14 -26
View File
@@ -181,7 +181,7 @@ class AttributedStringBuilderTests: XCTestCase {
}
func testEventIdLink() async {
let eventId = "$eventidentifier:matrix.org"
let eventId = "$eventidentifier"
let string = "The event is \(eventId)."
checkMatrixEntityLinkIn(attributedString: await attributedStringBuilder.fromHTML(string), expected: eventId)
checkMatrixEntityLinkIn(attributedString: await attributedStringBuilder.fromPlain(string), expected: eventId)
@@ -254,10 +254,8 @@ class AttributedStringBuilderTests: XCTestCase {
XCTAssertEqual(attributedStringBuilder.blockquoteCoalescedComponentsFrom(attributedString)?.count, 1)
for run in attributedString.runs {
if run.elementX.blockquote != nil {
return
}
for run in attributedString.runs where run.elementX.blockquote ?? false {
return
}
XCTFail("Couldn't find blockquote")
@@ -280,10 +278,8 @@ class AttributedStringBuilderTests: XCTestCase {
XCTAssertEqual(attributedStringBuilder.blockquoteCoalescedComponentsFrom(attributedString)?.count, 3)
for run in attributedString.runs {
if run.elementX.blockquote != nil {
return
}
for run in attributedString.runs where run.elementX.blockquote ?? false {
return
}
XCTFail("Couldn't find blockquote")
@@ -310,10 +306,8 @@ class AttributedStringBuilderTests: XCTestCase {
XCTAssertEqual(coalescedComponents.first?.attributedString.runs.count, 3, "Link not present in the component")
var foundBlockquoteAndLink = false
for run in attributedString.runs {
if run.elementX.blockquote != nil, run.link != nil {
foundBlockquoteAndLink = true
}
for run in attributedString.runs where run.elementX.blockquote ?? false && run.link != nil {
foundBlockquoteAndLink = true
}
XCTAssertNotNil(foundBlockquoteAndLink, "Couldn't find blockquote or link")
@@ -336,10 +330,8 @@ class AttributedStringBuilderTests: XCTestCase {
XCTAssertEqual(attributedStringBuilder.blockquoteCoalescedComponentsFrom(attributedString)?.count, 1)
var numberOfBlockquotes = 0
for run in attributedString.runs {
if run.elementX.blockquote != nil, run.link != nil {
numberOfBlockquotes += 1
}
for run in attributedString.runs where run.elementX.blockquote ?? false && run.link != nil {
numberOfBlockquotes += 1
}
XCTAssertEqual(numberOfBlockquotes, 3, "Couldn't find all the blockquotes")
@@ -365,10 +357,8 @@ class AttributedStringBuilderTests: XCTestCase {
XCTAssertEqual(attributedStringBuilder.blockquoteCoalescedComponentsFrom(attributedString)?.count, 6)
var numberOfBlockquotes = 0
for run in attributedString.runs {
if run.elementX.blockquote != nil, run.link != nil {
numberOfBlockquotes += 1
}
for run in attributedString.runs where run.elementX.blockquote ?? false && run.link != nil {
numberOfBlockquotes += 1
}
XCTAssertEqual(numberOfBlockquotes, 3, "Couldn't find all the blockquotes")
@@ -384,11 +374,9 @@ class AttributedStringBuilderTests: XCTestCase {
XCTAssertEqual(attributedString.runs.count, 3)
for run in attributedString.runs {
if run.link != nil {
XCTAssertEqual(run.link?.path, expected)
return
}
for run in attributedString.runs where run.link != nil {
XCTAssertEqual(run.link?.path, expected)
return
}
XCTFail("Couldn't find expected value.")