ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-03 16:10:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent duplicated timeline items from crashing the diffable datasource

Browse Source
This commit is contained in:
Stefan Ceriu
2023-02-02 17:54:37 +02:00
committed by Stefan Ceriu
parent cbfd2d1cca
commit 3f900df3de
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Services/Timeline/TimelineController/RoomTimelineController.swift
+10 -2
View File
@@ -231,6 +231,8 @@ class RoomTimelineController: RoomTimelineControllerProtocol {
var newTimelineItems = [RoomTimelineItemProtocol]() var newTimelineItems = [RoomTimelineItemProtocol]()
var canBackPaginate = true var canBackPaginate = true
var isBackPaginating = false var isBackPaginating = false
var createdIdentifiers = [String: Bool]()
for (index, itemProxy) in timelineProvider.itemsPublisher.value.enumerated() { for (index, itemProxy) in timelineProvider.itemsPublisher.value.enumerated() {
if Task.isCancelled { if Task.isCancelled {
@@ -245,7 +247,13 @@ class RoomTimelineController: RoomTimelineControllerProtocol {
switch itemProxy { switch itemProxy {
case .event(let eventItemProxy): case .event(let eventItemProxy):
if let timelineItem = timelineItemFactory.buildTimelineItemFor(eventItemProxy: eventItemProxy, groupState: groupState) { if let timelineItem = timelineItemFactory.buildTimelineItemFor(eventItemProxy: eventItemProxy, groupState: groupState) {
newTimelineItems.append(timelineItem) #warning("This works around duplicated items coming out of the SDK, remove once fixed")
if createdIdentifiers[timelineItem.id] == nil {
newTimelineItems.append(timelineItem)
createdIdentifiers[timelineItem.id] = true
} else {
MXLog.error("Found duplicated timeline item, ignoring")
}
} }
case .virtual(let virtualItem): case .virtual(let virtualItem):
switch virtualItem { switch virtualItem {
@@ -274,7 +282,7 @@ class RoomTimelineController: RoomTimelineControllerProtocol {
if Task.isCancelled { if Task.isCancelled {
return return
} }
timelineItems = newTimelineItems timelineItems = newTimelineItems
callbacks.send(.updatedTimelineItems) callbacks.send(.updatedTimelineItems)