Knocking feature polishing part 2 (#3738)

* improved implementation of the unknown state

* forget button in the banned state

* error handling for forbidden access

* added the forget function

fixed DMs, and updated preview tests

* removed banned room proxy

* code polishing and test improvement

ElementX/Sources/Services/Client/ClientProxy.swift

@@ -413,6 +413,9 @@ class ClientProxy: ClientProxyProtocol {
             await waitForRoomToSync(roomID: roomID, timeout: .seconds(30))
             
             return .success(())
+        } catch ClientError.MatrixApi(.forbidden, _, _) {
+            MXLog.error("Failed joining roomAlias: \(roomID) forbidden")
+            return .failure(.forbiddenAccess)
         } catch {
             MXLog.error("Failed joining roomID: \(roomID) with error: \(error)")
             return .failure(.sdkError(error))
@@ -426,6 +429,9 @@ class ClientProxy: ClientProxyProtocol {
             await waitForRoomToSync(roomID: room.id(), timeout: .seconds(30))
             
             return .success(())
+        } catch ClientError.MatrixApi(.forbidden, _, _) {
+            MXLog.error("Failed joining roomAlias: \(roomAlias) forbidden")
+            return .failure(.forbiddenAccess)
         } catch {
             MXLog.error("Failed joining roomAlias: \(roomAlias) with error: \(error)")
             return .failure(.sdkError(error))

ElementX/Sources/Services/Client/ClientProxyProtocol.swift

@@ -30,6 +30,7 @@ enum ClientProxyLoadingState {
 
 enum ClientProxyError: Error {
     case sdkError(Error)
+    case forbiddenAccess
     
     case invalidMedia
     case invalidServerName

ElementX/Sources/Services/Room/RoomPreview/RoomPreviewProxy.swift

@@ -32,4 +32,14 @@ final class RoomPreviewProxy: RoomPreviewProxyProtocol {
                                               senderRoomMember: senderRoomMember)
         }
     }
+    
+    func forgetRoom() async -> Result<Void, RoomProxyError> {
+        do {
+            try await roomPreview.forget()
+            return .success(())
+        } catch {
+            MXLog.error("Failed forgetting the room with error: \(error)")
+            return .failure(.sdkError(error))
+        }
+    }
 }

ElementX/Sources/Services/Room/RoomPreview/RoomPreviewProxyProtocol.swift

@@ -11,4 +11,7 @@ import Foundation
 protocol RoomPreviewProxyProtocol {
     var info: RoomPreviewInfoProxy { get }
     var ownMembershipDetails: RoomMembershipDetailsProxyProtocol? { get async }
+    
+    /// Use this function to forget the room, should only be used if the current user membership is `banned`
+    func forgetRoom() async -> Result<Void, RoomProxyError>
 }

ElementX/Sources/Services/Room/RoomProxyProtocol.swift

@@ -22,8 +22,8 @@ enum RoomProxyType {
     case joined(JoinedRoomProxyProtocol)
     case invited(InvitedRoomProxyProtocol)
     case knocked(KnockedRoomProxyProtocol)
-    case left
     case banned
+    case left
 }
 
 // sourcery: AutoMockable