ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-04 01:20:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use mock log files for the BugReportScreenViewModelTests. (#4257)

Browse Source 
The array could be empty if a previous test deleted the logs.
This commit is contained in:
Doug
2025-06-26 12:36:13 +01:00
committed by GitHub
parent 4b05a6194c
commit 373fa205ba
2 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Screens/BugReportScreen/BugReportScreenViewModel.swift
+3 -1
View File
@@ -14,7 +14,7 @@ class BugReportScreenViewModel: BugReportScreenViewModelType, BugReportScreenVie
private let bugReportService: BugReportServiceProtocol private let bugReportService: BugReportServiceProtocol
private let clientProxy: ClientProxyProtocol? private let clientProxy: ClientProxyProtocol?
private let logFiles = Tracing.logFiles private let logFiles: [URL]
private let actionsSubject: PassthroughSubject<BugReportScreenViewModelAction, Never> = .init() private let actionsSubject: PassthroughSubject<BugReportScreenViewModelAction, Never> = .init()
// periphery:ignore - when set to nil this is automatically cancelled // periphery:ignore - when set to nil this is automatically cancelled
@@ -26,10 +26,12 @@ class BugReportScreenViewModel: BugReportScreenViewModelType, BugReportScreenVie
init(bugReportService: BugReportServiceProtocol, init(bugReportService: BugReportServiceProtocol,
clientProxy: ClientProxyProtocol?, clientProxy: ClientProxyProtocol?,
logFiles: [URL] = Tracing.logFiles,
screenshot: UIImage?, screenshot: UIImage?,
isModallyPresented: Bool) { isModallyPresented: Bool) {
self.bugReportService = bugReportService self.bugReportService = bugReportService
self.clientProxy = clientProxy self.clientProxy = clientProxy
self.logFiles = logFiles
let canSendLogFiles = Self.validate(logFiles) let canSendLogFiles = Self.validate(logFiles)
let bindings = BugReportScreenViewStateBindings(reportText: "", sendingLogsEnabled: canSendLogFiles, canContact: false) let bindings = BugReportScreenViewStateBindings(reportText: "", sendingLogsEnabled: canSendLogFiles, canContact: false)
UnitTests/Sources/BugReportScreenViewModelTests.swift
+11 -3
View File
@@ -11,6 +11,8 @@ import XCTest
@MainActor @MainActor
class BugReportScreenViewModelTests: XCTestCase { class BugReportScreenViewModelTests: XCTestCase {
let logFiles: [URL] = [URL(filePath: "/path/to/file1.log"), URL(filePath: "/path/to/file2.log")]
enum TestError: Error { enum TestError: Error {
case testError case testError
} }
@@ -19,6 +21,7 @@ class BugReportScreenViewModelTests: XCTestCase {
let clientProxy = ClientProxyMock(.init(userID: "@mock.client.com")) let clientProxy = ClientProxyMock(.init(userID: "@mock.client.com"))
let viewModel = BugReportScreenViewModel(bugReportService: BugReportServiceMock(), let viewModel = BugReportScreenViewModel(bugReportService: BugReportServiceMock(),
clientProxy: clientProxy, clientProxy: clientProxy,
logFiles: logFiles,
screenshot: nil, screenshot: nil,
isModallyPresented: false) isModallyPresented: false)
let context = viewModel.context let context = viewModel.context
@@ -32,6 +35,7 @@ class BugReportScreenViewModelTests: XCTestCase {
let clientProxy = ClientProxyMock(.init(userID: "@mock.client.com")) let clientProxy = ClientProxyMock(.init(userID: "@mock.client.com"))
let viewModel = BugReportScreenViewModel(bugReportService: BugReportServiceMock(), let viewModel = BugReportScreenViewModel(bugReportService: BugReportServiceMock(),
clientProxy: clientProxy, clientProxy: clientProxy,
logFiles: logFiles,
screenshot: UIImage.actions, screenshot: UIImage.actions,
isModallyPresented: false) isModallyPresented: false)
let context = viewModel.context let context = viewModel.context
@@ -44,7 +48,9 @@ class BugReportScreenViewModelTests: XCTestCase {
let clientProxy = ClientProxyMock(.init(userID: "@mock.client.com")) let clientProxy = ClientProxyMock(.init(userID: "@mock.client.com"))
let viewModel = BugReportScreenViewModel(bugReportService: BugReportServiceMock(), let viewModel = BugReportScreenViewModel(bugReportService: BugReportServiceMock(),
clientProxy: clientProxy, clientProxy: clientProxy,
screenshot: nil, isModallyPresented: false) logFiles: logFiles,
screenshot: nil,
isModallyPresented: false)
let context = viewModel.context let context = viewModel.context
XCTAssertNil(context.viewState.screenshot) XCTAssertNil(context.viewState.screenshot)
context.send(viewAction: .attachScreenshot(UIImage.actions)) context.send(viewAction: .attachScreenshot(UIImage.actions))
@@ -64,7 +70,9 @@ class BugReportScreenViewModelTests: XCTestCase {
let viewModel = BugReportScreenViewModel(bugReportService: mockService, let viewModel = BugReportScreenViewModel(bugReportService: mockService,
clientProxy: clientProxy, clientProxy: clientProxy,
screenshot: nil, isModallyPresented: false) logFiles: logFiles,
screenshot: nil,
isModallyPresented: false)
let context = viewModel.context let context = viewModel.context
context.reportText = "This will succeed" context.reportText = "This will succeed"
@@ -86,7 +94,7 @@ class BugReportScreenViewModelTests: XCTestCase {
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.curve25519, "THECURVEKEYKEY") XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.curve25519, "THECURVEKEYKEY")
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.ed25519, "THEEDKEYKEY") XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.ed25519, "THEEDKEYKEY")
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.text, "This will succeed") XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.text, "This will succeed")
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.logFiles?.isEmpty, false) XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.logFiles, logFiles)
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.canContact, false) XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.canContact, false)
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.githubLabels, []) XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.githubLabels, [])
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.files, []) XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.files, [])