ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-04 01:20:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixing a crash that happened when leaving the room through the details screen (#2160)

Browse Source
This commit is contained in:
Mauro
2023-11-23 18:24:37 +01:00
committed by GitHub
parent 058429b637
commit 33d36826a2
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/FlowCoordinators/RoomFlowCoordinator.swift
+2 -3
View File
@@ -410,10 +410,9 @@ class RoomFlowCoordinator: FlowCoordinatorProtocol {
} }
private func dismissRoom(animated: Bool) { private func dismissRoom(animated: Bool) {
// Setting the detail coordinator to nil afirst allows the dismiss to work properly // DON'T CHANGE THE ORDER IN WHICH POP AND SET ARE DONE, IT CAN CAUSE A CRASH
// if followed immediately by another navigation on iPhone
navigationSplitCoordinator.setDetailCoordinator(nil, animated: animated)
navigationStackCoordinator.popToRoot(animated: false) navigationStackCoordinator.popToRoot(animated: false)
navigationSplitCoordinator.setDetailCoordinator(nil, animated: animated)
roomProxy = nil roomProxy = nil
timelineController = nil timelineController = nil
changelog.d/pr-2160.bugfix
+1
View File
@@ -0,0 +1 @@
Fixed a crash that happened when leaving a room through the details screen.