Improve TimelineAccessibilityModifier

2026-11-04 19:44:05 +00:00 · 2023-11-06 16:56:14 +01:00
parent f7f3404312
commit 30e8753663
4 changed files with 15 additions and 9 deletions
@@ -87,6 +87,7 @@ struct TimelineItemBubbledStylerView<Content: View>: View {
                    .lineLimit(1)
                    .padding(.vertical, senderNameVerticalPadding)
            }
+            // sender info are read inside the `TimelineAccessibilityModifier`
            .accessibilityHidden(true)
            .onTapGesture {
                context.send(viewAction: .tappedOnUser(userID: timelineItem.sender.id))
@@ -99,14 +100,6 @@ struct TimelineItemBubbledStylerView<Content: View>: View {
        // Figma overlaps reactions by 3
        VStack(alignment: alignment, spacing: -3) {
            messageBubble
-                .accessibilityRepresentation {
-                    VStack(spacing: 0) {
-                        Text(timelineItem.sender.displayName ?? timelineItem.sender.id)
-                            // Workaround: fixes VoiceOver frames offset when children accessibility element aren't combined
-                            .frame(height: 0)
-                        messageBubble
-                    }
-                }
                .timelineAccessibility(timelineItem)
            
            if !timelineItem.properties.reactions.isEmpty {