ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-03 16:10:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert weak media provider (#4483)

Browse Source 
* Revert "Address the real lifetime issue of the SDK's `Client` by making `Context.mediaProvider` weak. (#4466)"

This reverts commit c794144ef1.

* Better docs.
This commit is contained in:
Doug
2025-09-08 17:48:58 +01:00
committed by GitHub
parent 90504d89c8
commit 2f2e6f6226
58 changed files with 161 additions and 380 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Screens/Spaces/Common/SpaceHeaderView.swift
+3 -1
View File
@@ -160,12 +160,14 @@ struct SpaceHeaderMembersView: View {
}
struct SpaceHeaderView_Previews: PreviewProvider, TestablePreview {
static let mediaProvider = MediaProviderMock(configuration: .init())
static let spaces = makeSpaceRooms()
static var previews: some View {
VStack(spacing: 0) {
ForEach(spaces, id: \.id) { space in
SpaceHeaderView(spaceRoomProxy: space, mediaProvider: .mock)
SpaceHeaderView(spaceRoomProxy: space, mediaProvider: mediaProvider)
}
}
}
ElementX/Sources/Screens/Spaces/Common/SpaceRoomCell.swift
+3 -1
View File
@@ -134,6 +134,8 @@ struct SpaceRoomCellButtonStyle: ButtonStyle {
}
struct SpaceRoomCell_Previews: PreviewProvider, TestablePreview {
static let mediaProvider = MediaProviderMock(configuration: .init())
static let spaces = [SpaceRoomProxyProtocol].mockSpaceList
static var previews: some View {
@@ -141,7 +143,7 @@ struct SpaceRoomCell_Previews: PreviewProvider, TestablePreview {
ForEach(spaces, id: \.id) { space in
SpaceRoomCell(spaceRoomProxy: space,
isSelected: false,
mediaProvider: .mock) { _ in }
mediaProvider: mediaProvider) { _ in }
}
}
}