ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-03 16:10:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

use UIIimage to generate the local thumbnail for the avatar image so that snapshotting works fine and performance are improved

Browse Source
This commit is contained in:
Mauro Romito
2026-01-15 17:06:27 +01:00
committed by Mauro
parent 648caa4e82
commit 2f11eb7b65
10 changed files with 44 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Screens/CreateRoomScreen/CreateRoomScreenModels.swift
+14 -2
View File
@@ -6,7 +6,7 @@
// Please see LICENSE files in the repository root for full details.
//
import Foundation
import SwiftUI
enum CreateRoomScreenErrorType: Error {
case failedCreatingRoom
@@ -31,7 +31,19 @@ struct CreateRoomScreenViewState: BindableState {
let isKnockingFeatureEnabled: Bool
var aliasLocalPart: String
var bindings: CreateRoomScreenViewStateBindings
var avatarMediaInfo: MediaInfo?
var avatarMediaInfo: MediaInfo? {
didSet {
switch avatarMediaInfo {
case .image(_, let thumbnailURL, _):
avatarImage = UIImage(contentsOfFile: thumbnailURL.path(percentEncoded: false))
default:
avatarImage = nil
}
}
}
var avatarImage: UIImage?
var canCreateRoom: Bool {
!roomName.isEmpty && aliasErrors.isEmpty
}
ElementX/Sources/Screens/CreateRoomScreen/View/CreateRoomScreen.swift
+14 -18
View File
@@ -103,21 +103,17 @@ struct CreateRoomScreen: View {
focus = nil
context.showAttachmentConfirmationDialog = true
} label: {
if let url = context.viewState.avatarMediaInfo?.thumbnailURL {
AsyncImage(url: url) { image in
image
.resizable()
.aspectRatio(contentMode: .fill)
} placeholder: {
ProgressView()
}
.scaledFrame(size: 70, relativeTo: .title)
.clipShape(context.viewState.isSpace ? AnyShape(RoundedRectangle(cornerRadius: 16)) : AnyShape(Circle()))
.overlay(alignment: .bottomTrailing) {
editAvatarBadge
.scaledOffset(x: 12, y: 4, relativeTo: .title)
.accessibilityHidden(true)
}
if let avatarImage = context.viewState.avatarImage {
Image(uiImage: avatarImage)
.resizable()
.aspectRatio(contentMode: .fill)
.scaledFrame(size: 70, relativeTo: .title)
.clipShape(context.viewState.isSpace ? AnyShape(RoundedRectangle(cornerRadius: 16)) : AnyShape(Circle()))
.overlay(alignment: .bottomTrailing) {
editAvatarBadge
.scaledOffset(x: 12, y: 4, relativeTo: .title)
.accessibilityHidden(true)
}
} else {
CompoundIcon(\.takePhoto, size: .medium, relativeTo: .title)
.foregroundColor(.compound.iconPrimary)
@@ -143,7 +139,7 @@ struct CreateRoomScreen: View {
}
.accessibilityIdentifier(A11yIdentifiers.createRoomScreen.mediaPicker)
if context.viewState.avatarMediaInfo?.thumbnailURL != nil {
if context.viewState.avatarImage != nil {
Button(L10n.actionRemove, role: .destructive) {
context.send(viewAction: .removeImage)
}
@@ -407,7 +403,7 @@ struct CreateRoom_Previews: PreviewProvider, TestablePreview {
CreateRoomScreen(context: avatarViewModel.context)
}
.previewDisplayName("Create Room with avatar")
.snapshotPreferences(expect: avatarViewModel.context.$viewState.map { $0.avatarMediaInfo != nil })
.snapshotPreferences(expect: avatarViewModel.context.$viewState.map { $0.avatarImage != nil })
NavigationStack {
CreateRoomScreen(context: spaceViewModel.context)
@@ -418,7 +414,7 @@ struct CreateRoom_Previews: PreviewProvider, TestablePreview {
CreateRoomScreen(context: spaceWithAvatarViewModel.context)
}
.previewDisplayName("Create Space with avatar")
.snapshotPreferences(expect: spaceWithAvatarViewModel.context.$viewState.map { $0.avatarMediaInfo != nil })
.snapshotPreferences(expect: spaceWithAvatarViewModel.context.$viewState.map { $0.avatarImage != nil })
NavigationStack {
CreateRoomScreen(context: publicRoomViewModel.context)