mirror of
https://github.com/Novaloop-AG/element-x-ios.git
synced 2026-11-02 21:33:26 +00:00
Point the classic app identifiers at HealthChat rather than Element (#1)
ClassicAppManager migrates an existing user's session and encryption keys by reading the legacy app's app-group container and keychain. Those identifiers defaulted to Element's own, which this team cannot provision, so loadAccounts() threw invalidAppGroupIdentifier — caught and logged, never surfaced. Since both apps share a bundle id, the result would be every existing user silently logged out and losing local history when they update. The legacy identifiers belong to HealthChat and are provisionable under the same team, so repoint them rather than dropping them. Also stop sending accounts without key backup to a dead end. Upstream shows those users a sheet asking them to open Element Classic and set up backup first, but this update replaces that app and nothing registers its URL scheme, so the sheet's only button does nothing. Sign in directly instead: the user re-verifies the device and loses only history that by definition has no backup.
This commit is contained in:
@@ -23,6 +23,7 @@
|
||||
<key>keychain-access-groups</key>
|
||||
<array>
|
||||
<string>$(KEYCHAIN_ACCESS_GROUP_IDENTIFIER)</string>
|
||||
<string>$(CLASSIC_APP_KEYCHAIN_ACCESS_GROUP_IDENTIFIER)</string>
|
||||
</array>
|
||||
</dict>
|
||||
</plist>
|
||||
|
||||
@@ -129,12 +129,17 @@ targets:
|
||||
com.apple.developer.usernotifications.communication: true
|
||||
com.apple.security.app-sandbox: true
|
||||
com.apple.security.application-groups:
|
||||
# HealthChat: dropped $(CLASSIC_APP_GROUP_IDENTIFIER) (group.im.vector) — owned by Element's team, not provisionable here.
|
||||
# HealthChat: dropped $(CLASSIC_APP_GROUP_IDENTIFIER) — not because it is un-provisionable,
|
||||
# but because it resolves to group.ch.healthchat, the same value as $(APP_GROUP_IDENTIFIER)
|
||||
# below. The legacy container is already entitled; listing it twice would duplicate the entry.
|
||||
- $(APP_GROUP_IDENTIFIER)
|
||||
com.apple.security.network.client: true
|
||||
keychain-access-groups:
|
||||
# HealthChat: dropped $(CLASSIC_APP_KEYCHAIN_ACCESS_GROUP_IDENTIFIER) (im.vector.app.*) — not provisionable here.
|
||||
- $(KEYCHAIN_ACCESS_GROUP_IDENTIFIER)
|
||||
# HealthChat: the legacy app's keychain group. ClassicAppManager reads the account and
|
||||
# crypto-store keys from here to migrate existing users. Same team prefix, so it is
|
||||
# provisionable — unlike Element's im.vector.app.* default in app.yml.
|
||||
- $(CLASSIC_APP_KEYCHAIN_ACCESS_GROUP_IDENTIFIER)
|
||||
|
||||
settings:
|
||||
base:
|
||||
|
||||
Reference in New Issue
Block a user