Remove the share_pos developer option. (#4406)

ElementX/Sources/Application/Settings/AppSettings.swift

@@ -60,7 +60,6 @@ final class AppSettings {
         case knockingEnabled
         case threadsEnabled
         case developerOptionsEnabled
-        case sharePosEnabledV2
         case multipleAttachmentUploadEnabled
         
         // Doug's tweaks 🔧
@@ -352,9 +351,6 @@ final class AppSettings {
     @UserPreference(key: UserDefaultsKeys.developerOptionsEnabled, defaultValue: isDevelopmentBuild, storageType: .userDefaults(store))
     var developerOptionsEnabled
     
-    @UserPreference(key: UserDefaultsKeys.sharePosEnabledV2, defaultValue: true, storageType: .userDefaults(store))
-    var sharePosEnabled
-    
     #endif
     
     // MARK: - Shared

ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/DeveloperOptionsScreenModels.swift

@@ -51,7 +51,6 @@ protocol DeveloperOptionsProtocol: AnyObject {
     var publicSearchEnabled: Bool { get set }
     var fuzzyRoomListSearchEnabled: Bool { get set }
     var knockingEnabled: Bool { get set }
-    var sharePosEnabled: Bool { get set }
 }
 
 extension AppSettings: DeveloperOptionsProtocol { }

ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/View/DeveloperOptionsScreen.swift

@@ -65,13 +65,6 @@ struct DeveloperOptionsScreen: View {
                 }
             }
             
-            Section("Sync") {
-                Toggle(isOn: $context.sharePosEnabled) {
-                    Text("Share pos")
-                    Text("Keep the sliding sync pos to make initial syncs faster. Requires an app restart to take effect. Might make the sync unstable.")
-                }
-            }
-            
             Section {
                 Toggle(isOn: $context.enableOnlySignedDeviceIsolationMode) {
                     Text("Exclude insecure devices when sending/receiving messages")

ElementX/Sources/Services/Client/ClientProxy.swift

@@ -1192,7 +1192,7 @@ private struct ClientProxyServices {
         let syncService = try await client
             .syncService()
             .withCrossProcessLock()
-            .withSharePos(enable: appSettings.sharePosEnabled)
+            .withSharePos(enable: true)
             .finish()
         
         let roomListService = syncService.roomListService()