From 1780b58e5867423c1208a093b88d89236632fbee Mon Sep 17 00:00:00 2001 From: Alfonso Grillo Date: Fri, 3 Nov 2023 16:04:03 +0100 Subject: [PATCH] Fix accessibility label for VoiceMessageButton --- .../Other/VoiceMessage/VoiceMessageButton.swift | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/ElementX/Sources/Other/VoiceMessage/VoiceMessageButton.swift b/ElementX/Sources/Other/VoiceMessage/VoiceMessageButton.swift index d4b6c7adc..30ed64829 100644 --- a/ElementX/Sources/Other/VoiceMessage/VoiceMessageButton.swift +++ b/ElementX/Sources/Other/VoiceMessage/VoiceMessageButton.swift @@ -56,6 +56,7 @@ struct VoiceMessageButton: View { .buttonStyle(VoiceMessageButtonStyle()) .disabled(state == .loading) .background(Circle().foregroundColor(.compound.bgCanvasDefault)) + .accessibilityLabel(accessibilityLabel) } @ViewBuilder @@ -65,7 +66,6 @@ struct VoiceMessageButton: View { ProgressView() case .playing, .paused: let imageAsset = state == .playing ? Asset.Images.mediaPause : Asset.Images.mediaPlay - let accessibilityLabel = state == .playing ? L10n.a11yPause : L10n.a11yPlay let offset: CGFloat = state == .playing ? 0 : 2 Image(asset: imageAsset) @@ -73,7 +73,17 @@ struct VoiceMessageButton: View { .scaledToFit() .frame(width: imageWidth, height: imageHeight) .offset(x: offset) - .accessibilityLabel(accessibilityLabel) + } + } + + private var accessibilityLabel: String { + switch state { + case .loading: + return "" + case .playing: + return L10n.a11yPause + case .paused: + return L10n.a11yPlay } } }