ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-04 10:33:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove the focused ComposerToolbar accessibility test and preview

Browse Source 
The automatically focused keyboard is creating false positives when running accessibility
tests and doesn't bring any value in the previews. Simplest solution is to remove it.
This commit is contained in:
Stefan Ceriu
2026-05-15 10:36:15 +03:00
parent e8c7d0761f
commit 16715ea1c2
5 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Screens/RoomScreen/ComposerToolbar/View/ComposerToolbar.swift
-2
View File
@@ -382,7 +382,6 @@ struct ComposerToolbar_Previews: PreviewProvider, TestablePreview {
static let timelineViewModel = TimelineViewModel.mock static let timelineViewModel = TimelineViewModel.mock
static let viewModel = ComposerToolbarViewModel.mock() static let viewModel = ComposerToolbarViewModel.mock()
static let focusedViewModel = ComposerToolbarViewModel.mock(focused: true, message: "Hello, World!")
static let editingViewModel = ComposerToolbarViewModel.mock(message: "Hello, Wrold!", mockMode: .editing) static let editingViewModel = ComposerToolbarViewModel.mock(message: "Hello, Wrold!", mockMode: .editing)
static let multiLineViewModel = ComposerToolbarViewModel.mock(message: "Hello, World! This is a loooong message that wraps onto multiple lines.") static let multiLineViewModel = ComposerToolbarViewModel.mock(message: "Hello, World! This is a loooong message that wraps onto multiple lines.")
static let voiceMessageRecordingViewModel = ComposerToolbarViewModel.mock(mockMode: .recordVoiceMessage) static let voiceMessageRecordingViewModel = ComposerToolbarViewModel.mock(mockMode: .recordVoiceMessage)
@@ -396,7 +395,6 @@ struct ComposerToolbar_Previews: PreviewProvider, TestablePreview {
static var previews: some View { static var previews: some View {
VStack(spacing: 8) { VStack(spacing: 8) {
ComposerToolbar(context: viewModel.context) ComposerToolbar(context: viewModel.context)
ComposerToolbar(context: focusedViewModel.context)
ComposerToolbar(context: editingViewModel.context) ComposerToolbar(context: editingViewModel.context)
ComposerToolbar(context: multiLineViewModel.context) ComposerToolbar(context: multiLineViewModel.context)
.padding(.bottom) .padding(.bottom)
PreviewTests/Sources/__Snapshots__/PreviewTests/composerToolbar.iPad-en-GB-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1 version https://git-lfs.github.com/spec/v1
oid sha256:26dbb222d7ae03c531acb6fd82c043fc2819aad37e22c090cb348eb88f275483 oid sha256:c6f2105f18b21ec044ac813a6660440e592a337dc4045e22b8cb5e1f934ceb59
size 148115 size 138667
PreviewTests/Sources/__Snapshots__/PreviewTests/composerToolbar.iPad-pseudo-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1 version https://git-lfs.github.com/spec/v1
oid sha256:7ac2bbfa49173552bee41680af46dc5e6f8314bda5a868d68c4ec9c97c366e15 oid sha256:da5a013fe99208a94b2a8202e034782c7ddea3ebd2041b2ab9d35208517caa7f
size 149170 size 139784
PreviewTests/Sources/__Snapshots__/PreviewTests/composerToolbar.iPhone-en-GB-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1 version https://git-lfs.github.com/spec/v1
oid sha256:5a8f18909e0ea65a8589e8cfeb958000ba103272985761f6a4218c94e8eeb1f0 oid sha256:a83cc66c77c262cea14b8efd474154bb3fd38331493bcfe4f56c2a0cc66844f8
size 100353 size 93078
PreviewTests/Sources/__Snapshots__/PreviewTests/composerToolbar.iPhone-pseudo-0.png
+2 -2
View File
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1 version https://git-lfs.github.com/spec/v1
oid sha256:799f8f5ba8c0648e90120aab9313f76835e60b4d81e3de96508465cd665ccd66 oid sha256:e1733b9e9e32df9fbfbe2d2220ca8698ac8005b60df92a30317d98d6fa14b0d4
size 102189 size 94918