From 12e8ffaf8774fa16ba8dafae72e1ded5fb16c8f5 Mon Sep 17 00:00:00 2001 From: Stefan Ceriu Date: Mon, 27 Nov 2023 10:43:02 +0200 Subject: [PATCH] Show the build number on the nightly app icons --- ci_scripts/ci_post_clone.sh | 2 +- fastlane/Fastfile | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/ci_scripts/ci_post_clone.sh b/ci_scripts/ci_post_clone.sh index dc6509661..4b2e9a397 100755 --- a/ci_scripts/ci_post_clone.sh +++ b/ci_scripts/ci_post_clone.sh @@ -7,7 +7,7 @@ setup_xcode_cloud_environment install_xcode_cloud_brew_dependencies if [ "$CI_WORKFLOW" = "Nightly" ]; then - bundle exec fastlane config_nightly + bundle exec fastlane config_nightly build_number:"$CI_BUILD_NUMBER" else bundle exec fastlane config_production fi diff --git a/fastlane/Fastfile b/fastlane/Fastfile index c5cc18860..a58e50b07 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -176,7 +176,10 @@ lane :integration_tests do ) end -lane :config_nightly do +lane :config_nightly do |options| + build_number = options[:build_number] + UI.user_error!("Invalid build number.") unless !build_number.to_s.empty? + target_file_path = "../project.yml" data = YAML.load_file target_file_path data["settings"]["BASE_APP_GROUP_IDENTIFIER"] = "io.element.nightly" @@ -194,7 +197,7 @@ lane :config_nightly do release_version = get_version_number(target: "ElementX") - update_app_icon(caption_text: "Nightly #{release_version}", modulate: "100,20,100") + update_app_icon(caption_text: "#{release_version}(#{build_number})", modulate: "100,20,100") end lane :config_production do @@ -449,7 +452,7 @@ private_lane :config_secrets do UI.user_error!("Invalid OTLP tracing username.") unless !otlp_tracing_username.to_s.empty? otlp_tracing_password = ENV["OTLP_TRACING_PASSWORD"] - UI.user_error!("Invalid OTLP tracing URL.") unless !otlp_tracing_password.to_s.empty? + UI.user_error!("Invalid OTLP tracing password.") unless !otlp_tracing_password.to_s.empty? set_xcconfig_value( path: './ElementX/SupportingFiles/secrets.xcconfig',