ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-03 16:10:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for a potential crash when building a removed timeline item. (#2533)

Browse Source
This commit is contained in:
Doug
2024-03-06 12:33:32 +00:00
committed by GitHub
parent 7754b9b8dc
commit 129b898f4f
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ElementX/Sources/Screens/RoomScreen/RoomScreenInteractionHandler.swift
+8 -4
View File
@@ -503,7 +503,9 @@ class RoomScreenInteractionHandler {
await voiceMessageRecorder.stopRecording() await voiceMessageRecorder.stopRecording()
} }
let audioPlayerState = audioPlayerState(for: itemID) guard let audioPlayerState = audioPlayerState(for: itemID) else {
fatalError("Audio player not found for \(itemID)")
}
// Ensure this one is attached // Ensure this one is attached
if !audioPlayerState.isAttached { if !audioPlayerState.isAttached {
@@ -546,13 +548,15 @@ class RoomScreenInteractionHandler {
await playerState.updateState(progress: progress) await playerState.updateState(progress: progress)
} }
func audioPlayerState(for itemID: TimelineItemIdentifier) -> AudioPlayerState { func audioPlayerState(for itemID: TimelineItemIdentifier) -> AudioPlayerState? {
guard let timelineItem = timelineController.timelineItems.firstUsingStableID(itemID) else { guard let timelineItem = timelineController.timelineItems.firstUsingStableID(itemID) else {
fatalError("TimelineItem \(itemID) not found") MXLog.error("TimelineItem \(itemID) not found")
return nil
} }
guard let voiceMessageRoomTimelineItem = timelineItem as? VoiceMessageRoomTimelineItem else { guard let voiceMessageRoomTimelineItem = timelineItem as? VoiceMessageRoomTimelineItem else {
fatalError("Invalid TimelineItem type (expecting `VoiceMessageRoomTimelineItem` but found \(type(of: timelineItem)) instead") MXLog.error("Invalid TimelineItem type (expecting `VoiceMessageRoomTimelineItem` but found \(type(of: timelineItem)) instead")
return nil
} }
if let playerState = mediaPlayerProvider.playerState(for: .timelineItemIdentifier(itemID)) { if let playerState = mediaPlayerProvider.playerState(for: .timelineItemIdentifier(itemID)) {