Removing dead code part 2 (#2235)

Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>

ElementX/Sources/Services/Room/RoomMember/RoomMemberProxy.swift

@@ -39,12 +39,6 @@ final class RoomMemberProxy: RoomMemberProxyProtocol {
 
     lazy var membership = member.membership()
 
-    lazy var isNameAmbiguous = member.isNameAmbiguous()
-
-    lazy var powerLevel = Int(member.powerLevel())
-
-    lazy var normalizedPowerLevel = Int(member.normalizedPowerLevel())
-
     lazy var isAccountOwner = member.isAccountUser()
 
     lazy var isIgnored = member.isIgnored()

ElementX/Sources/Services/Room/RoomMember/RoomMemberProxyProtocol.swift

@@ -28,9 +28,6 @@ protocol RoomMemberProxyProtocol: AnyObject {
     var displayName: String? { get }
     var avatarURL: URL? { get }
     var membership: MembershipState { get }
-    var isNameAmbiguous: Bool { get }
-    var powerLevel: Int { get }
-    var normalizedPowerLevel: Int { get }
     var isAccountOwner: Bool { get }
     var isIgnored: Bool { get }
     var canInviteUsers: Bool { get }

ElementX/Sources/Services/Room/RoomProxy.swift

@@ -34,6 +34,7 @@ class RoomProxy: RoomProxyProtocol {
     private var sendMessageBackgroundTask: BackgroundTaskProtocol?
     
     private(set) var displayName: String?
+    // periphery:ignore - required for instance retention in the rust codebase
     private var roomInfoObservationToken: TaskHandle?
     private var subscribedForUpdates = false
 
@@ -104,10 +105,6 @@ class RoomProxy: RoomProxyProtocol {
         room.topic()
     }
     
-    var isJoined: Bool {
-        room.membership() == .joined
-    }
-    
     var membership: Membership {
         room.membership()
     }
@@ -128,10 +125,6 @@ class RoomProxy: RoomProxyProtocol {
         (try? room.isEncrypted()) ?? false
     }
     
-    var isTombstoned: Bool {
-        room.isTombstoned()
-    }
-    
     var hasOngoingCall: Bool {
         room.hasActiveRoomCall()
     }
@@ -140,10 +133,6 @@ class RoomProxy: RoomProxyProtocol {
         room.canonicalAlias()
     }
     
-    var alternativeAliases: [String] {
-        room.alternativeAliases()
-    }
-    
     var hasUnreadNotifications: Bool {
         roomListItem.hasUnreadNotifications()
     }
@@ -163,36 +152,6 @@ class RoomProxy: RoomProxyProtocol {
     var activeMembersCount: Int {
         Int(room.activeMembersCount())
     }
-
-    func loadAvatarURLForUserId(_ userId: String) async -> Result<URL?, RoomProxyError> {
-        do {
-            guard let urlString = try await Task.dispatch(on: lowPriorityDispatchQueue, {
-                try self.room.memberAvatarUrl(userId: userId)
-            }) else {
-                return .success(nil)
-            }
-            
-            guard let avatarURL = URL(string: urlString) else {
-                MXLog.error("Invalid avatar URL string: \(String(describing: urlString))")
-                return .failure(.failedRetrievingMemberAvatarURL)
-            }
-            
-            return .success(avatarURL)
-        } catch {
-            return .failure(.failedRetrievingMemberAvatarURL)
-        }
-    }
-    
-    func loadDisplayNameForUserId(_ userId: String) async -> Result<String?, RoomProxyError> {
-        do {
-            let displayName = try await Task.dispatch(on: lowPriorityDispatchQueue) {
-                try self.room.memberDisplayName(userId: userId)
-            }
-            return .success(displayName)
-        } catch {
-            return .failure(.failedRetrievingMemberDisplayName)
-        }
-    }
     
     func redact(_ eventID: String) async -> Result<Void, RoomProxyError> {
         sendMessageBackgroundTask = await backgroundTaskService.startBackgroundTask(withName: backgroundTaskName, isReusable: true)
@@ -290,16 +249,6 @@ class RoomProxy: RoomProxyProtocol {
         }
     }
     
-    func inviter() async -> RoomMemberProxyProtocol? {
-        let inviter = await Task.dispatch(on: .global()) {
-            self.room.inviter()
-        }
-        
-        return inviter.map {
-            RoomMemberProxy(member: $0, backgroundTaskService: self.backgroundTaskService)
-        }
-    }
-    
     func rejectInvitation() async -> Result<Void, RoomProxyError> {
         await Task.dispatch(on: .global()) {
             do {

ElementX/Sources/Services/Room/RoomProxyProtocol.swift

@@ -19,8 +19,6 @@ import Foundation
 import MatrixRustSDK
 
 enum RoomProxyError: Error, Equatable {
-    case failedRetrievingMemberAvatarURL
-    case failedRetrievingMemberDisplayName
     case failedRedactingEvent
     case failedReportingContent
     case failedRetrievingMember
@@ -46,11 +44,9 @@ protocol RoomProxyProtocol {
     var isPublic: Bool { get }
     var isSpace: Bool { get }
     var isEncrypted: Bool { get }
-    var isTombstoned: Bool { get }
     var membership: Membership { get }
     var hasOngoingCall: Bool { get }
     var canonicalAlias: String? { get }
-    var alternativeAliases: [String] { get }
     var hasUnreadNotifications: Bool { get }
     var ownUserID: String { get }
     
@@ -62,9 +58,7 @@ protocol RoomProxyProtocol {
     var avatarURL: URL? { get }
 
     var members: CurrentValuePublisher<[RoomMemberProxyProtocol], Never> { get }
-    
-    var invitedMembersCount: Int { get }
-    
+        
     var joinedMembersCount: Int { get }
     
     var activeMembersCount: Int { get }
@@ -73,14 +67,7 @@ protocol RoomProxyProtocol {
     
     var timeline: TimelineProxyProtocol { get }
     
-    /// A timeline providing just polls related events
-    var pollHistoryTimeline: TimelineProxyProtocol { get }
-    
     func subscribeForUpdates() async
-
-    func loadAvatarURLForUserId(_ userId: String) async -> Result<URL?, RoomProxyError>
-    
-    func loadDisplayNameForUserId(_ userId: String) async -> Result<String?, RoomProxyError>
     
     func redact(_ eventID: String) async -> Result<Void, RoomProxyError>
     
@@ -93,8 +80,6 @@ protocol RoomProxyProtocol {
     func updateMembers() async
 
     func getMember(userID: String) async -> Result<RoomMemberProxyProtocol, RoomProxyError>
-
-    func inviter() async -> RoomMemberProxyProtocol?
     
     func rejectInvitation() async -> Result<Void, RoomProxyError>
     

ElementX/Sources/Services/Room/RoomSummary/RoomEventStringBuilder.swift

@@ -48,9 +48,9 @@ struct RoomEventStringBuilder {
             
             let messageType = messageContent.msgtype()
             return messageEventStringBuilder.buildAttributedString(for: messageType, senderDisplayName: senderDisplayName, prefixWithSenderName: true)
-        case .state(let stateKey, let state):
+        case .state(_, let state):
             return stateEventStringBuilder
-                .buildString(for: state, stateKey: stateKey, sender: sender, isOutgoing: isOutgoing)
+                .buildString(for: state, sender: sender, isOutgoing: isOutgoing)
                 .map(AttributedString.init)
         case .roomMembership(let userID, let change):
             return stateEventStringBuilder