Removing dead code part 2 (#2235)

Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>

ElementX/Sources/Services/Notification/NotificationConstants.swift

@@ -23,7 +23,6 @@ enum NotificationConstants {
         static let unreadCount = "unread_count"
         static let pusherNotificationClientIdentifier = "pusher_notification_client_identifier"
         static let receiverIdentifier = "receiver_id"
-        static let notificationIdentifier = "notification_identifier"
     }
 
     enum Category {

ElementX/Sources/Services/Notification/Proxy/NotificationItemProxy.swift

@@ -45,10 +45,6 @@ struct NotificationItemProxy: NotificationItemProxyProtocol {
         notificationItem.roomInfo.displayName
     }
 
-    var roomCanonicalAlias: String? {
-        notificationItem.roomInfo.canonicalAlias
-    }
-
     var isRoomDirect: Bool {
         notificationItem.roomInfo.isDirect
     }
@@ -96,27 +92,17 @@ struct EmptyNotificationItemProxy: NotificationItemProxyProtocol {
     var senderID: String { "" }
 
     var senderDisplayName: String? { nil }
-
-    var senderAvatarURL: String? { nil }
-
+    
     var roomDisplayName: String { "" }
 
-    var roomCanonicalAlias: String? { nil }
-
-    var roomAvatarURL: String? { nil }
-
     var isNoisy: Bool { false }
 
     var isRoomDirect: Bool { false }
 
-    var isRoomEncrypted: Bool? { nil }
-
     var senderAvatarMediaSource: MediaSourceProxy? { nil }
 
     var roomAvatarMediaSource: MediaSourceProxy? { nil }
 
-    var notificationIdentifier: String { "" }
-
     var roomJoinedMembers: Int { 0 }
     
     var hasMention: Bool { false }

ElementX/Sources/Services/Notification/Proxy/NotificationItemProxyProtocol.swift

@@ -35,8 +35,6 @@ protocol NotificationItemProxyProtocol {
 
     var roomDisplayName: String { get }
 
-    var roomCanonicalAlias: String? { get }
-
     var roomAvatarMediaSource: MediaSourceProxy? { get }
 
     var roomJoinedMembers: Int { get }