ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-03 06:55:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a crash when attempting to send a bug report with excessively large logs. (#4243)

Browse Source 
* Alert the user when there are excessively large log files.
This commit is contained in:
Doug
2025-06-24 09:47:20 +01:00
committed by GitHub
parent 0bf6ed1c63
commit 0f9d700c99
10 changed files with 50 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
UnitTests/Sources/BugReportScreenViewModelTests.swift
+2 -2
View File
@@ -79,14 +79,14 @@ class BugReportScreenViewModelTests: XCTestCase {
context.send(viewAction: .submit)
try await deferred.fulfill()
XCTAssert(mockService.submitBugReportProgressListenerCallsCount == 1)
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.userID, "@mock.client.com")
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.deviceID, "ABCDEFGH")
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.curve25519, "THECURVEKEYKEY")
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.ed25519, "THEEDKEYKEY")
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.text, "This will succeed")
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.includeLogs, true)
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.logFiles?.isEmpty, false)
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.canContact, false)
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.githubLabels, [])
XCTAssertEqual(mockService.submitBugReportProgressListenerReceivedArguments?.bugReport.files, [])
UnitTests/Sources/BugReportServiceTests.swift
+2 -2
View File
@@ -31,7 +31,7 @@ class BugReportServiceTests: XCTestCase {
ed25519: nil,
curve25519: nil,
text: "i cannot send message",
includeLogs: true,
logFiles: [URL(filePath: "/logs/1.log"), URL(filePath: "/logs/2.log")],
canContact: false,
githubLabels: [],
files: [])
@@ -76,7 +76,7 @@ class BugReportServiceTests: XCTestCase {
ed25519: nil,
curve25519: nil,
text: "i cannot send message",
includeLogs: true,
logFiles: Tracing.logFiles,
canContact: false,
githubLabels: [],
files: [])