ehealthsolutions/element-x-ios
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-ios.git synced 2026-11-04 01:20:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

DM Details View (#744)

Browse Source 
* Basic implementation completed but it requires some bug fixing and polishing (+4 squashed commits)
Squashed commits:
[43f0064e] now the content of the room details reflects the expected dm details content when the conditions are met
[fe6f2b5e] replaced existing headers with a composable and reusable HeaderView
[3c00120a] now the members are fetched every time the room is opened
[421d539b] refactored the members fetching to be immediate in case the room could be a direct chat

* polished the code and fixed some bugs that prevented the updated state of the members to be displayed in the room details view (+1 squashed commit)
Squashed commits:
[6bf98473] fix for the button not being destructive in room details screen

* removed copy button and updated copy

* moved a file and renamed header view

* addressed all PR comments

* sdk bump

* UI tests

* unit tests

* changelog

* updated mocks

* removed a duplicated signature in a mock
This commit is contained in:
Mauro
2023-04-03 13:18:19 +02:00
committed by GitHub
parent 220138d492
commit 0f858d977f
35 changed files with 1241 additions and 241 deletions
Download Patch File Download Diff File Expand all files Collapse all files
UnitTests/Sources/RoomMemberDetailsViewModelTests.swift
+15 -30
View File
@@ -28,12 +28,7 @@ class RoomMemberDetailsViewModelTests: XCTestCase {
roomMemberProxyMock = RoomMemberProxyMock.mockAlice
viewModel = RoomMemberDetailsViewModel(roomMemberProxy: roomMemberProxyMock, mediaProvider: MockMediaProvider())
XCTAssertEqual(context.viewState.name, "Alice")
XCTAssertFalse(context.viewState.isAccountOwner)
XCTAssertFalse(context.viewState.isIgnored)
XCTAssertEqual(context.viewState.userID, "@alice:matrix.org")
XCTAssertEqual(context.viewState.permalink, URL(string: "https://matrix.to/#/@alice:matrix.org"))
XCTAssertEqual(context.viewState.avatarURL, nil)
XCTAssertEqual(context.viewState.details, RoomMemberDetails(withProxy: roomMemberProxyMock))
XCTAssertNil(context.ignoreUserAlert)
XCTAssertNil(context.errorAlert)
}
@@ -48,15 +43,15 @@ class RoomMemberDetailsViewModelTests: XCTestCase {
context.send(viewAction: .showIgnoreAlert)
await Task.yield()
XCTAssertEqual(context.ignoreUserAlert, IgnoreUserAlertItem(action: .ignore))
XCTAssertEqual(context.ignoreUserAlert, .init(action: .ignore))
context.send(viewAction: .ignoreConfirmed)
await Task.yield()
XCTAssertTrue(context.viewState.isProcessingIgnoreRequest)
XCTAssertFalse(context.viewState.isIgnored)
XCTAssertFalse(context.viewState.details.isIgnored)
try await Task.sleep(for: .milliseconds(10))
XCTAssertFalse(context.viewState.isProcessingIgnoreRequest)
XCTAssertTrue(context.viewState.isIgnored)
XCTAssertTrue(context.viewState.details.isIgnored)
}
func testIgnoreFailure() async throws {
@@ -69,16 +64,16 @@ class RoomMemberDetailsViewModelTests: XCTestCase {
context.send(viewAction: .showIgnoreAlert)
await Task.yield()
XCTAssertEqual(context.ignoreUserAlert, IgnoreUserAlertItem(action: .ignore))
XCTAssertEqual(context.ignoreUserAlert, .init(action: .ignore))
context.send(viewAction: .ignoreConfirmed)
await Task.yield()
XCTAssertTrue(context.viewState.isProcessingIgnoreRequest)
XCTAssertFalse(context.viewState.isIgnored)
XCTAssertFalse(context.viewState.details.isIgnored)
try await Task.sleep(for: .milliseconds(10))
XCTAssertFalse(context.viewState.isProcessingIgnoreRequest)
XCTAssertNotNil(context.errorAlert)
XCTAssertFalse(context.viewState.isIgnored)
XCTAssertFalse(context.viewState.details.isIgnored)
}
func testUnignoreSuccess() async throws {
@@ -91,15 +86,15 @@ class RoomMemberDetailsViewModelTests: XCTestCase {
context.send(viewAction: .showUnignoreAlert)
await Task.yield()
XCTAssertEqual(context.ignoreUserAlert, IgnoreUserAlertItem(action: .unignore))
XCTAssertEqual(context.ignoreUserAlert, .init(action: .unignore))
context.send(viewAction: .unignoreConfirmed)
await Task.yield()
XCTAssertTrue(context.viewState.isProcessingIgnoreRequest)
XCTAssertTrue(context.viewState.isIgnored)
XCTAssertTrue(context.viewState.details.isIgnored)
try await Task.sleep(for: .milliseconds(10))
XCTAssertFalse(context.viewState.isProcessingIgnoreRequest)
XCTAssertFalse(context.viewState.isIgnored)
XCTAssertFalse(context.viewState.details.isIgnored)
}
func testUnignoreFailure() async throws {
@@ -112,15 +107,15 @@ class RoomMemberDetailsViewModelTests: XCTestCase {
context.send(viewAction: .showUnignoreAlert)
await Task.yield()
XCTAssertEqual(context.ignoreUserAlert, IgnoreUserAlertItem(action: .unignore))
XCTAssertEqual(context.ignoreUserAlert, .init(action: .unignore))
context.send(viewAction: .unignoreConfirmed)
await Task.yield()
XCTAssertTrue(context.viewState.isProcessingIgnoreRequest)
XCTAssertTrue(context.viewState.isIgnored)
XCTAssertTrue(context.viewState.details.isIgnored)
try await Task.sleep(for: .milliseconds(10))
XCTAssertFalse(context.viewState.isProcessingIgnoreRequest)
XCTAssertTrue(context.viewState.isIgnored)
XCTAssertTrue(context.viewState.details.isIgnored)
XCTAssertNotNil(context.errorAlert)
}
@@ -128,12 +123,7 @@ class RoomMemberDetailsViewModelTests: XCTestCase {
roomMemberProxyMock = RoomMemberProxyMock.mockMe
viewModel = RoomMemberDetailsViewModel(roomMemberProxy: roomMemberProxyMock, mediaProvider: MockMediaProvider())
XCTAssertEqual(context.viewState.name, "Me")
XCTAssertTrue(context.viewState.isAccountOwner)
XCTAssertFalse(context.viewState.isIgnored)
XCTAssertEqual(context.viewState.userID, "@me:matrix.org")
XCTAssertEqual(context.viewState.permalink, URL(string: "https://matrix.to/#/@me:matrix.org"))
XCTAssertEqual(context.viewState.avatarURL, URL.picturesDirectory)
XCTAssertEqual(context.viewState.details, RoomMemberDetails(withProxy: roomMemberProxyMock))
XCTAssertNil(context.ignoreUserAlert)
XCTAssertNil(context.errorAlert)
}
@@ -142,12 +132,7 @@ class RoomMemberDetailsViewModelTests: XCTestCase {
roomMemberProxyMock = RoomMemberProxyMock.mockIgnored
viewModel = RoomMemberDetailsViewModel(roomMemberProxy: roomMemberProxyMock, mediaProvider: MockMediaProvider())
XCTAssertEqual(context.viewState.name, "Ignored")
XCTAssertFalse(context.viewState.isAccountOwner)
XCTAssertTrue(context.viewState.isIgnored)
XCTAssertEqual(context.viewState.userID, "@ignored:matrix.org")
XCTAssertEqual(context.viewState.permalink, URL(string: "https://matrix.to/#/@ignored:matrix.org"))
XCTAssertEqual(context.viewState.avatarURL, nil)
XCTAssertEqual(context.viewState.details, RoomMemberDetails(withProxy: roomMemberProxyMock))
XCTAssertNil(context.ignoreUserAlert)
XCTAssertNil(context.errorAlert)
}