Switch to Xcode 14 and handle the UICollectionView-backed List. (#229)

* Fix Timeline on Xcode 14/iOS 16

Raise requirement to iOS 16+
Reduce pagination jumping.
Sonarcloud fixes.
Fix verification test.
Adopt if let optional { syntax.

* Remove unused ScrollViewReader

The ScrollViewReader didn't appear to change the behaviour.

* Fix warnings on Run Scripts.

Run script build phase 'SwiftLint' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase.

ElementX/Sources/Services/Analytics/AnalyticsService.swift

@@ -52,7 +52,7 @@ class AnalyticsService {
             return .failure(.accountDataFailure)
         case .success(let settings):
             // The id has already be set so we are done here.
-            if let settings = settings, settings.id != nil {
+            if let settings, settings.id != nil {
                 return .success(settings)
             }
             

ElementX/Sources/Services/Analytics/PostHogAnalyticsClient.swift

@@ -73,7 +73,7 @@ class PostHogAnalyticsClient: AnalyticsClientProtocol {
     }
     
     func updateUserProperties(_ userProperties: AnalyticsEvent.UserProperties) {
-        guard let pendingUserProperties = pendingUserProperties else {
+        guard let pendingUserProperties else {
             pendingUserProperties = userProperties
             return
         }