refactor: manage member sheet in timeline

better implementation

updated tests

Update ElementX/Sources/Screens/Timeline/TimelineViewModel.swift

Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>

fix

ElementX/Sources/Screens/RoomMemberListScreen/View/RoomMembersListManageMemberSheet.swift

@@ -1,96 +0,0 @@
-//
-// Copyright 2024 New Vector Ltd.
-//
-// SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
-// Please see LICENSE files in the repository root for full details.
-//
-
-import Compound
-import SwiftUI
-
-struct RoomMembersListManageMemberSheet: View {
-    let member: RoomMemberDetails
-    let actions: [RoomMembersListScreenManagementDetails.Action]
-    
-    @ObservedObject var context: RoomMembersListScreenViewModel.Context
-    
-    var body: some View {
-        Form {
-            AvatarHeaderView(member: member,
-                             avatarSize: .user(on: .memberDetails),
-                             mediaProvider: context.mediaProvider) {
-                EmptyView()
-            }
-            
-            Section {
-                ListRow(label: .default(title: L10n.screenRoomMemberListManageMemberUserInfo,
-                                        icon: \.userProfileSolid),
-                        kind: .button {
-                            context.send(viewAction: .showMemberDetails(member))
-                        })
-                
-                if actions.contains(.kick) {
-                    ListRow(label: .default(title: L10n.screenRoomMemberListManageMemberRemove,
-                                            icon: \.close),
-                            kind: .button {
-                                context.send(viewAction: .kickMember(member))
-                            })
-                }
-                
-                if actions.contains(.ban) {
-                    ListRow(label: .default(title: L10n.screenRoomMemberListManageMemberBan,
-                                            icon: \.block,
-                                            role: .destructive),
-                            kind: .button {
-                                context.send(viewAction: .banMember(member))
-                            })
-                }
-            }
-        }
-        .compoundList()
-        .scrollBounceBehavior(.basedOnSize)
-        .presentationDragIndicator(.visible)
-        .presentationDetents([.large, .fraction(0.54)]) // Maybe find a way to use the ideal height somehow?
-    }
-}
-
-struct RoomMembersListManageMemberSheet_Previews: PreviewProvider, TestablePreview {
-    static let viewModel = RoomMembersListScreenViewModel.mock
-    
-    static var previews: some View {
-        RoomMembersListManageMemberSheet(member: .init(withProxy: RoomMemberProxyMock.mockDan),
-                                         actions: [.kick, .ban],
-                                         context: viewModel.context)
-            .previewDisplayName("Joined")
-        
-        RoomMembersListManageMemberSheet(member: .init(withProxy: RoomMemberProxyMock.mockBanned[3]),
-                                         actions: [],
-                                         context: viewModel.context)
-            .previewDisplayName("Banned")
-    }
-}
-
-struct RoomMembersListManageMemberSheetLive_Previews: PreviewProvider {
-    static let viewModel = RoomMembersListScreenViewModel.mock
-    
-    static var previews: some View {
-        Color.clear
-            .sheet(isPresented: .constant(true)) {
-                RoomMembersListManageMemberSheet(member: .init(withProxy: RoomMemberProxyMock.mockDan),
-                                                 actions: [.kick, .ban],
-                                                 context: viewModel.context)
-            }
-            .previewDisplayName("Sheet")
-    }
-}
-
-private extension RoomMembersListScreenViewModel {
-    static var mock: RoomMembersListScreenViewModel {
-        RoomMembersListScreenViewModel(initialMode: .members,
-                                       clientProxy: ClientProxyMock(.init()),
-                                       roomProxy: JoinedRoomProxyMock(.init(members: .allMembersAsAdmin)),
-                                       mediaProvider: MediaProviderMock(configuration: .init()),
-                                       userIndicatorController: ServiceLocator.shared.userIndicatorController,
-                                       analytics: ServiceLocator.shared.analytics)
-    }
-}

ElementX/Sources/Screens/RoomMemberListScreen/View/RoomMembersListScreen.swift

@@ -47,8 +47,8 @@ struct RoomMembersListScreen: View {
         .autocorrectionDisabled()
         .background(Color.compound.bgCanvasDefault.ignoresSafeArea())
         .navigationTitle(L10n.commonPeople)
-        .sheet(item: $context.memberToManage) {
-            RoomMembersListManageMemberSheet(member: $0.member, actions: $0.actions, context: context)
+        .sheet(item: $context.manageMemeberViewModel) {
+            ManageRoomMemberSheetView(context: $0.context)
         }
         .alert(item: $context.alertInfo)
         .toolbar { toolbar }