Secure backup tweaks (#2277)

* Use a custom SDK build that might fix incomplete recovery state false positives. Enable chat backup by default

* Get rid of the chat backup feature flag

* Fix force unwrap warning

* Fix long line warning

* Prevent the recovery key confirmation banner popping up before the verification state is fetched. Stop showing secure backup user avatar and menu badges while the session is not verified.

* Switch back to the release version of the SDK

* Fix inconsistent session verification states, improve/simplify how to deal with it

* Fix unit tests

* Cleanup and hopefully simplify home screen banner presentations
This commit is contained in:
Stefan Ceriu
2023-12-21 17:08:29 +02:00
committed by GitHub
parent d148827eae
commit 0ae71f740d
18 changed files with 67 additions and 82 deletions
@@ -32,12 +32,9 @@ final class UserSessionTests: XCTestCase {
func test_whenUserSessionReceivesSyncUpdateAndSessionControllerRetrievedAndSessionNotVerified_sessionVerificationNeededEventReceived() throws {
let expectation = expectation(description: "SessionVerificationNeeded expectation")
userSession.callbacks.sink { callback in
switch callback {
case .sessionVerificationNeeded:
userSession.sessionVerificationState.sink { isVerified in
if let isVerified, isVerified == false {
expectation.fulfill()
default:
break
}
}
.store(in: &cancellables)
@@ -1,3 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:2b391abfdd2172848ae1a2510d50ea597e337425793560d01959b57429972ba2
size 106343
oid sha256:ceef950f0e74453a572d90b85cea1a3ba2a702595358efb36d76285d51acee15
size 106872