Secure backup tweaks (#2277)

* Use a custom SDK build that might fix incomplete recovery state false positives. Enable chat backup by default

* Get rid of the chat backup feature flag

* Fix force unwrap warning

* Fix long line warning

* Prevent the recovery key confirmation banner popping up before the verification state is fetched. Stop showing secure backup user avatar and menu badges while the session is not verified.

* Switch back to the release version of the SDK

* Fix inconsistent session verification states, improve/simplify how to deal with it

* Fix unit tests

* Cleanup and hopefully simplify home screen banner presentations

ElementX/Sources/Screens/Settings/SettingsScreen/SettingsScreenModels.swift

@@ -42,7 +42,6 @@ struct SettingsScreenViewState: BindableState {
     var userAvatarURL: URL?
     var userDisplayName: String?
     var isSessionVerified: Bool?
-    var chatBackupEnabled = false
     var showSecureBackupBadge = false
     var showDeveloperOptions: Bool
     

ElementX/Sources/Screens/Settings/SettingsScreen/SettingsScreenViewModel.swift

@@ -44,8 +44,9 @@ class SettingsScreenViewModel: SettingsScreenViewModelType, SettingsScreenViewMo
             .weakAssign(to: \.state.userDisplayName, on: self)
             .store(in: &cancellables)
         
-        appSettings.$chatBackupEnabled
-            .weakAssign(to: \.state.chatBackupEnabled, on: self)
+        userSession.sessionVerificationState
+            .receive(on: DispatchQueue.main)
+            .weakAssign(to: \.state.isSessionVerified, on: self)
             .store(in: &cancellables)
         
         userSession.clientProxy.secureBackupController.recoveryKeyState
@@ -53,33 +54,14 @@ class SettingsScreenViewModel: SettingsScreenViewModelType, SettingsScreenViewMo
             .sink { [weak self] state in
                 guard let self else { return }
                 
-                self.state.showSecureBackupBadge = (state == .incomplete || state == .disabled) && appSettings.chatBackupEnabled
+                self.state.showSecureBackupBadge = (state == .incomplete || state == .disabled)
             }
             .store(in: &cancellables)
         
         Task {
             await userSession.clientProxy.loadUserAvatarURL()
             await userSession.clientProxy.loadUserDisplayName()
-            
-            if let sessionVerificationController = userSession.sessionVerificationController,
-               case let .success(isVerified) = await sessionVerificationController.isVerified() {
-                state.isSessionVerified = isVerified
-            }
         }
-        
-        userSession.callbacks
-            .receive(on: DispatchQueue.main)
-            .sink { [weak self] callback in
-                switch callback {
-                case .sessionVerificationNeeded:
-                    self?.state.isSessionVerified = false
-                case .didVerifySession:
-                    self?.state.isSessionVerified = true
-                default:
-                    break
-                }
-            }
-            .store(in: &cancellables)
     }
     
     override func process(viewAction: SettingsScreenViewAction) {

ElementX/Sources/Screens/Settings/SettingsScreen/View/SettingsScreen.swift

@@ -88,7 +88,7 @@ struct SettingsScreen: View {
                     ListRow(label: .default(title: L10n.actionCompleteVerification,
                                             icon: \.checkCircle),
                             kind: .button { context.send(viewAction: .sessionVerification) })
-                } else if context.viewState.chatBackupEnabled {
+                } else {
                     ListRow(label: .default(title: L10n.commonChatBackup,
                                             icon: Image(asset: Asset.Images.secureBackupIcon)),
                             details: context.viewState.showSecureBackupBadge ? .icon(secureBackupBadge) : nil,