ehealthsolutions/element-x-android
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-android.git synced 2026-11-03 06:55:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Drop the comments from the redaction resolution

Browse Source 
Review feedback: the filtered-out result and the test name already state
why an unmappable redaction must not notify.
This commit is contained in:
hayaksi1
2026-08-09 15:31:19 +03:00
parent bc20e64c61
commit fec71aaf4d
2 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/DefaultNotifiableEventResolver.kt
-4
View File
@@ -284,10 +284,6 @@ class DefaultNotifiableEventResolver(
// Note: this case will be handled below // Note: this case will be handled below
val redactedEventId = content.redactedEventId val redactedEventId = content.redactedEventId
if (redactedEventId == null) { if (redactedEventId == null) {
// Treat it as filtered out rather than as an error: an unknown error is turned
// into a visible "you have N notifications" fallback plus a battery banner, so a
// redaction we cannot map would notify about a message that was just deleted.
// See https://github.com/element-hq/element-x-android/issues/5766
Timber.tag(loggerTag.value).w("Ignoring redaction notification with no redactedEventId.") Timber.tag(loggerTag.value).w("Ignoring redaction notification with no redactedEventId.")
throw NotificationResolverException.EventFilteredOut throw NotificationResolverException.EventFilteredOut
} else { } else {
libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/notifications/DefaultNotifiableEventResolverTest.kt
-2
View File
@@ -834,8 +834,6 @@ class DefaultNotifiableEventResolverTest : RobolectricTest() {
val request = aPushRequest(A_SESSION_ID, A_ROOM_ID, AN_EVENT_ID, "firebase") val request = aPushRequest(A_SESSION_ID, A_ROOM_ID, AN_EVENT_ID, "firebase")
val result = sut.resolveEvents(A_SESSION_ID, listOf(request)) val result = sut.resolveEvents(A_SESSION_ID, listOf(request))
assertThat(result.getEvent(request)?.getOrNull()).isNull() assertThat(result.getEvent(request)?.getOrNull()).isNull()
// Must be EventFilteredOut and not an error: the result processor renders a fallback
// notification for any other exception, which is the bug in #5766.
assertThat(result.getEvent(request)?.exceptionOrNull()).isEqualTo(NotificationResolverException.EventFilteredOut) assertThat(result.getEvent(request)?.exceptionOrNull()).isEqualTo(NotificationResolverException.EventFilteredOut)
} }