mirror of
https://github.com/Novaloop-AG/element-x-android.git
synced 2026-11-02 21:32:34 +00:00
Merge pull request #2292 from element-hq/feature/bma/gitSha
Git sha and branch in log
This commit is contained in:
+2
@@ -202,6 +202,8 @@ class DefaultBugReporter @Inject constructor(
|
||||
// add some github labels
|
||||
builder.addFormDataPart("label", buildMeta.versionName)
|
||||
builder.addFormDataPart("label", buildMeta.flavorDescription)
|
||||
builder.addFormDataPart("branch_name", buildMeta.gitBranchName)
|
||||
|
||||
if (crashCallStack.isNotEmpty() && withCrashLogs) {
|
||||
builder.addFormDataPart("label", "crash")
|
||||
}
|
||||
|
||||
+6
-2
@@ -80,7 +80,7 @@ class DefaultBugReporterTest {
|
||||
server.shutdown()
|
||||
assertThat(onUploadCancelledCalled).isFalse()
|
||||
assertThat(onUploadFailedCalled).isFalse()
|
||||
assertThat(progressValues.size).isEqualTo(11)
|
||||
assertThat(progressValues.size).isEqualTo(EXPECTED_NUMBER_OF_PROGRESS_VALUE)
|
||||
assertThat(onUploadSucceedCalled).isTrue()
|
||||
}
|
||||
|
||||
@@ -131,7 +131,7 @@ class DefaultBugReporterTest {
|
||||
assertThat(onUploadCancelledCalled).isFalse()
|
||||
assertThat(onUploadFailedCalled).isTrue()
|
||||
assertThat(onUploadFailedReason).isEqualTo("An error body")
|
||||
assertThat(progressValues.size).isEqualTo(11)
|
||||
assertThat(progressValues.size).isEqualTo(EXPECTED_NUMBER_OF_PROGRESS_VALUE)
|
||||
assertThat(onUploadSucceedCalled).isFalse()
|
||||
}
|
||||
|
||||
@@ -153,4 +153,8 @@ class DefaultBugReporterTest {
|
||||
bugReporterUrlProvider = { server.url("/") }
|
||||
)
|
||||
}
|
||||
|
||||
companion object {
|
||||
private const val EXPECTED_NUMBER_OF_PROGRESS_VALUE = 12
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user