Rename Event for clarity

features/createroom/impl/src/main/kotlin/io/element/android/features/createroom/impl/configureroom/ConfigureRoomPresenter.kt

@@ -102,7 +102,7 @@ class ConfigureRoomPresenter @Inject constructor(
                         AvatarAction.TakePhoto -> if (cameraPermissionState.permissionGranted) {
                             cameraPhotoPicker.launch()
                         } else {
-                            cameraPermissionState.eventSink(PermissionsEvents.OpenSystemDialog)
+                            cameraPermissionState.eventSink(PermissionsEvents.AskPermissionToUser)
                         }
                         AvatarAction.Remove -> dataStore.setAvatarUri(uri = null)
                     }

features/ftue/impl/src/main/kotlin/io/element/android/features/ftue/impl/notifications/NotificationsOptInPresenter.kt

@@ -65,7 +65,7 @@ class NotificationsOptInPresenter @AssistedInject constructor(
                     if (notificationsPermissionsState.permissionGranted) {
                         callback.onNotificationsOptInFinished()
                     } else {
-                        notificationsPermissionsState.eventSink(PermissionsEvents.OpenSystemDialog)
+                        notificationsPermissionsState.eventSink(PermissionsEvents.AskPermissionToUser)
                     }
                 }
                 NotificationsOptInEvents.NotNowClicked -> {

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/user/editprofile/EditUserProfilePresenter.kt

@@ -94,7 +94,7 @@ class EditUserProfilePresenter @AssistedInject constructor(
                         AvatarAction.TakePhoto -> if (cameraPermissionState.permissionGranted) {
                             cameraPhotoPicker.launch()
                         } else {
-                            cameraPermissionState.eventSink.invoke(PermissionsEvents.OpenSystemDialog)
+                            cameraPermissionState.eventSink.invoke(PermissionsEvents.AskPermissionToUser)
                         }
                         AvatarAction.Remove -> userAvatarUri = null
                     }

features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/edit/RoomDetailsEditPresenter.kt

@@ -119,7 +119,7 @@ class RoomDetailsEditPresenter @Inject constructor(
                         AvatarAction.TakePhoto -> if (cameraPermissionState.permissionGranted) {
                             cameraPhotoPicker.launch()
                         } else {
-                            cameraPermissionState.eventSink(PermissionsEvents.OpenSystemDialog)
+                            cameraPermissionState.eventSink(PermissionsEvents.AskPermissionToUser)
                         }
                         AvatarAction.Remove -> roomAvatarUri = null
                     }

libraries/permissions/api/src/main/kotlin/io/element/android/libraries/permissions/api/PermissionsEvents.kt

@@ -17,6 +17,6 @@
 package io.element.android.libraries.permissions.api
 
 sealed interface PermissionsEvents {
-    data object OpenSystemDialog : PermissionsEvents
+    data object AskPermissionToUser : PermissionsEvents
     data object CloseDialog : PermissionsEvents
 }

libraries/permissions/api/src/main/kotlin/io/element/android/libraries/permissions/api/PermissionsView.kt

@@ -69,7 +69,7 @@ fun PermissionsView(
                 content = textToShow,
                 submitText = "Request permission",
                 onSubmitClicked = {
-                    state.eventSink.invoke(PermissionsEvents.OpenSystemDialog)
+                    state.eventSink.invoke(PermissionsEvents.AskPermissionToUser)
                 },
                 onCancelClicked = {
                     state.eventSink.invoke(PermissionsEvents.CloseDialog)

libraries/permissions/impl/src/main/kotlin/io/element/android/libraries/permissions/impl/DefaultPermissionsPresenter.kt

@@ -110,7 +110,7 @@ class DefaultPermissionsPresenter @AssistedInject constructor(
                 PermissionsEvents.CloseDialog -> {
                     showDialog.value = false
                 }
-                PermissionsEvents.OpenSystemDialog -> {
+                PermissionsEvents.AskPermissionToUser -> {
                     if (permissionState.status !is PermissionStatus.Granted && isAlreadyDenied) {
                         showDialog.value = true
                     } else {

libraries/permissions/impl/src/test/kotlin/io/element/android/libraries/permissions/impl/DefaultPermissionsPresenterTest.kt

@@ -91,7 +91,7 @@ class DefaultPermissionsPresenterTest {
         }.test {
             skipItems(1)
             val initialState = awaitItem()
-            initialState.eventSink.invoke(PermissionsEvents.OpenSystemDialog)
+            initialState.eventSink.invoke(PermissionsEvents.AskPermissionToUser)
             val withDialogState = awaitItem()
             assertThat(withDialogState.showDialog).isTrue()
             withDialogState.eventSink.invoke(PermissionsEvents.CloseDialog)
@@ -120,7 +120,7 @@ class DefaultPermissionsPresenterTest {
         }.test {
             val initialState = awaitItem()
             assertThat(initialState.showDialog).isFalse()
-            initialState.eventSink.invoke(PermissionsEvents.OpenSystemDialog)
+            initialState.eventSink.invoke(PermissionsEvents.AskPermissionToUser)
             assertThat(permissionState.launchPermissionRequestCalled).isTrue()
             // User does not grant permission
             permissionStateProvider.userGiveAnswer(answer = false, firstTime = true)
@@ -154,7 +154,7 @@ class DefaultPermissionsPresenterTest {
         }.test {
             val initialState = awaitItem()
             assertThat(initialState.showDialog).isFalse()
-            initialState.eventSink.invoke(PermissionsEvents.OpenSystemDialog)
+            initialState.eventSink.invoke(PermissionsEvents.AskPermissionToUser)
             assertThat(permissionState.launchPermissionRequestCalled).isTrue()
             // User does not grant permission
             permissionStateProvider.userGiveAnswer(answer = false, firstTime = false)
@@ -192,7 +192,7 @@ class DefaultPermissionsPresenterTest {
         }.test {
             skipItems(1)
             val initialState = awaitItem()
-            initialState.eventSink.invoke(PermissionsEvents.OpenSystemDialog)
+            initialState.eventSink.invoke(PermissionsEvents.AskPermissionToUser)
             val withDialogState = awaitItem()
             assertThat(withDialogState.showDialog).isTrue()
             assertThat(withDialogState.permissionGranted).isFalse()
@@ -222,7 +222,7 @@ class DefaultPermissionsPresenterTest {
         }.test {
             val initialState = awaitItem()
             assertThat(initialState.showDialog).isFalse()
-            initialState.eventSink.invoke(PermissionsEvents.OpenSystemDialog)
+            initialState.eventSink.invoke(PermissionsEvents.AskPermissionToUser)
             assertThat(permissionState.launchPermissionRequestCalled).isTrue()
             // User grants permission
             permissionStateProvider.userGiveAnswer(answer = true, firstTime = true)

libraries/permissions/test/src/main/kotlin/io/element/android/libraries/permissions/test/FakePermissionsPresenter.kt

@@ -29,7 +29,7 @@ class FakePermissionsPresenter(
 
     private fun eventSink(events: PermissionsEvents) {
         when (events) {
-            PermissionsEvents.OpenSystemDialog -> state.value = state.value.copy(showDialog = true, permissionAlreadyAsked = true)
+            PermissionsEvents.AskPermissionToUser -> state.value = state.value.copy(showDialog = true, permissionAlreadyAsked = true)
             PermissionsEvents.CloseDialog -> state.value = state.value.copy(showDialog = false)
         }
     }