mirror of
https://github.com/Novaloop-AG/element-x-android.git
synced 2026-11-03 06:01:40 +00:00
Make sure we don't finish NotificationTapOpensTimeline until we've actually rendered the timeline event we need to focus on
This commit is contained in:
committed by
Jorge Martin Espinosa
parent
c6e0686dec
commit
f265a47243
+3
-1
@@ -206,6 +206,9 @@ class TimelinePresenter(
|
|||||||
focusOnEvent(event.eventId, focusRequestState)
|
focusOnEvent(event.eventId, focusRequestState)
|
||||||
}.start()
|
}.start()
|
||||||
is TimelineEvents.OnFocusEventRender -> {
|
is TimelineEvents.OnFocusEventRender -> {
|
||||||
|
// If there was a pending 'notification tap opens timeline' transaction, finish it now we're focused in the required event
|
||||||
|
analyticsService.finishLongRunningTransaction(NotificationTapOpensTimeline)
|
||||||
|
|
||||||
focusRequestState.value = focusRequestState.value.onFocusEventRender()
|
focusRequestState.value = focusRequestState.value.onFocusEventRender()
|
||||||
}
|
}
|
||||||
is TimelineEvents.ClearFocusRequestState -> {
|
is TimelineEvents.ClearFocusRequestState -> {
|
||||||
@@ -242,7 +245,6 @@ class TimelinePresenter(
|
|||||||
analyticsService.run {
|
analyticsService.run {
|
||||||
finishLongRunningTransaction(DisplayFirstTimelineItems)
|
finishLongRunningTransaction(DisplayFirstTimelineItems)
|
||||||
finishLongRunningTransaction(OpenRoom)
|
finishLongRunningTransaction(OpenRoom)
|
||||||
finishLongRunningTransaction(NotificationTapOpensTimeline)
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
.launchIn(this)
|
.launchIn(this)
|
||||||
|
|||||||
Reference in New Issue
Block a user