ehealthsolutions/element-x-android
3
0
Fork 0
mirror of https://github.com/Novaloop-AG/element-x-android.git synced 2026-11-03 06:55:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix wakelock not stopping early when notifications are disabled (#6424)

Browse Source 
If notifications for a device are disabled when there is no connection with the HS, the push registration will still exist, so the device can still receive push notifications.

In that cases, we were running into an issue where the wakelock for push notifications was started immediately after receiving a push but was never stopped and it ran for 3 minutes until its timeout, keeping the device awake for no reason.

This patch changes `DefaultPushHandler` so if we don't need the wakelock it returns `false` and we can stop the wakelock early.
This commit is contained in:
Jorge Martin Espinosa
2026-03-23 18:07:25 +01:00
committed by GitHub
parent 3a7faa8b76
commit f1708f6366
7 changed files with 157 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/push/test/src/main/kotlin/io/element/android/libraries/push/test/test/FakePushHandler.kt
+3 -3
View File
@@ -13,11 +13,11 @@ import io.element.android.libraries.pushproviders.api.PushHandler
import io.element.android.tests.testutils.lambda.lambdaError
class FakePushHandler(
private val handleResult: (PushData, String) -> Unit = { _, _ -> lambdaError() },
private val handleResult: (PushData, String) -> Boolean = { _, _ -> lambdaError() },
private val handleInvalidResult: (String, String) -> Unit = { _, _ -> lambdaError() },
) : PushHandler {
override suspend fun handle(pushData: PushData, providerInfo: String) {
handleResult(pushData, providerInfo)
override suspend fun handle(pushData: PushData, providerInfo: String): Boolean {
return handleResult(pushData, providerInfo)
}
override suspend fun handleInvalid(providerInfo: String, data: String) {